Skip to content

Conversation

@cijothomas
Copy link
Member

Incremental additions. Will keep reviewing and tweaking internal logs to make sure we can troubleshoot issues easily and consistently across signals.
This PR mostly adds debug level logs, and 1-3 INFO level.

@cijothomas cijothomas requested a review from a team as a code owner November 23, 2024 20:21
@codecov
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (ebeeea1) to head (e597b25).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/meter_provider.rs 90.9% 2 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 80.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2330   +/-   ##
=====================================
  Coverage   79.4%   79.5%           
=====================================
  Files        123     123           
  Lines      21271   21295   +24     
=====================================
+ Hits       16910   16935   +25     
+ Misses      4361    4360    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@cijothomas cijothomas merged commit 8c9babb into open-telemetry:main Nov 23, 2024
22 of 23 checks passed
@cijothomas cijothomas deleted the cijothomas/internallogs2 branch November 23, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants