Skip to content

Update CHANGELOGs for time changes in metrics aggregations #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cijothomas merged 4 commits into from
Dec 12, 2024
Merged

Update CHANGELOGs for time changes in metrics aggregations #2412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6698b2f
Update CHANGELOGs for time changes in metrics aggregations
fraillt Dec 11, 2024
179df26
Merge branch 'main' into update-change-log-for-aggregation-time-changes
cijothomas Dec 11, 2024
60b074d
Update opentelemetry-sdk/CHANGELOG.md
fraillt Dec 12, 2024
5235bcc
Merge branch 'main' into update-change-log-for-aggregation-time-changes
cijothomas Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions opentelemetry-sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## vNext

- *Breaking(Affects custom metric exporter authors only)* `start_time` and `time` is moved from DataPoints to aggregations (Sum, Gauge, Histogram, ExpoHistogram) see [#2377](https://github.com/open-telemetry/opentelemetry-rust/pull/2377) and [#2411](https://github.com/open-telemetry/opentelemetry-rust/pull/2411), to reduce memory.

- *Breaking* `start_time` is no longer optional for `Sum` aggregation, see [#2367](https://github.com/open-telemetry/opentelemetry-rust/pull/2367), but is still optional for `Gauge` aggregation see [#2389](https://github.com/open-telemetry/opentelemetry-rust/pull/2389).

- *Breaking*
- SimpleLogProcessor modified to be generic over `LogExporter` to
avoid dynamic dispatch to invoke exporter. If you were using
Expand Down
2 changes: 2 additions & 0 deletions opentelemetry-stdout/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## vNext

- *Breaking* time fields, `StartTime` and `EndTime` is printed on aggregation (Sum, Gauge, Histogram, ExpoHistogram) with 2 tabs, previously it was on aggregation data point, with 3 tabs, see [#2377](https://github.com/open-telemetry/opentelemetry-rust/pull/2377) and [#2411](https://github.com/open-telemetry/opentelemetry-rust/pull/2411).
Copy link
Member

@cijothomas cijothomas Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay to skipp changelog for stdout

Copy link
Contributor Author

@fraillt fraillt Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's important to mention this... I mean, my company use similar approach in production (have custom exporter that exports metrics as logs using log instead println). So I imagine that someone might rely on the format of stdout exporter.

Copy link
Member

@cijothomas cijothomas Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I imagine that someone might rely on the format of stdout exporter.

I don't think so. It's explicitly called out that stdout is only for learning purposes, and its output format should not be relied upon for anything.

https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-stdout/src/lib.rs#L1-L4

(Not a blocker for this PR, just sharing that stdout is not meant for that purpose)


## 0.27.0

Released 2024-Nov-11
Expand Down
Loading