Skip to content

Conversation

@lalitb
Copy link
Member

@lalitb lalitb commented Dec 12, 2024

Fixes: #2373

Changes

Pinning versions of tracing and tracing-core that are compatible with the version required to support name metadata in macros.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner December 12, 2024 09:31
@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.4%. Comparing base (fbc3c70) to head (1e48685).
Report is 391 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2418   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        122     122           
  Lines      21708   21708           
=====================================
  Hits       17255   17255           
  Misses      4453    4453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tracing-core = { version = "0.1", default-features = false }
# Using `tracing 0.1.40` because 0.1.39 (which is yanked) introduces the ability to set event names in macros,
# required for OpenTelemetry's internal logging macros.
tracing = { version = ">=0.1.40", default-features = false }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this particular version for internal logging only right? The appender can operate with "0.1" itself. Wondering if we should use separate ones for these, instead of forcing even appender to 0.1.40?

Not a blocker anyway as 0.1.40 is already an year old.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry before merge
Also left a non blocking question/comment.

@lalitb
Copy link
Member Author

lalitb commented Dec 15, 2024

Please add changelog entry before merge Also left a non blocking question/comment.

updated changelog. Regarding appender, I believe it can work at version 0.1. However things would be bit complex once we add otel internal logging in appender. Let me check if we can conditionally use the proper tracing version in appender as separate PR.

@lalitb lalitb merged commit c726c4d into open-telemetry:main Dec 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tracing minimum version dependency

2 participants