Skip to content

Version pinning for tracing and tracing-core #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalitb merged 5 commits into from
Dec 15, 2024
Merged

Version pinning for tracing and tracing-core #2418

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fde8271
update tracing version
lalitb Dec 12, 2024
2a14a88
update comment
lalitb Dec 12, 2024
6a317bc
Merge branch 'main' into update-tracing-version
cijothomas Dec 13, 2024
c7ad406
Merge branch 'main' into update-tracing-version
lalitb Dec 15, 2024
1e48685
update changelog
lalitb Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ tonic = { version = "0.12.3", default-features = false }
tonic-build = "0.12"
tokio = { version = "1", default-features = false }
tokio-stream = "0.1"
tracing = { version = "0.1", default-features = false }
tracing-core = { version = "0.1", default-features = false }
# Using `tracing 0.1.40` because 0.1.39 (which is yanked) introduces the ability to set event names in macros,
# required for OpenTelemetry's internal logging macros.
tracing = { version = ">=0.1.40", default-features = false }
Copy link
Member

@cijothomas cijothomas Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this particular version for internal logging only right? The appender can operate with "0.1" itself. Wondering if we should use separate ones for these, instead of forcing even appender to 0.1.40?

Not a blocker anyway as 0.1.40 is already an year old.

# `tracing-core >=0.1.33` is required for compatibility with `tracing >=0.1.40`.
tracing-core = { version = ">=0.1.33", default-features = false }
tracing-subscriber = { version = "0.3", default-features = false }
url = { version = "2.5", default-features = false }
Loading