Skip to content

Conversation

@cijothomas
Copy link
Member

Fixes #2189

@cijothomas cijothomas requested a review from a team as a code owner January 22, 2025 02:57
@codecov
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.8%. Comparing base (90b0dd4) to head (643b1f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2529   +/-   ##
=====================================
  Coverage   77.8%   77.8%           
=====================================
  Files        123     123           
  Lines      23059   23059           
=====================================
  Hits       17940   17940           
  Misses      5119    5119           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely documented.

/// runtime. Logs can emitted from any thread, including tokio runtime
/// threads.
/// - `reqwest-blocking-client`: LoggerProvider may be created anywhere, but
/// logs must be emitted from a non-tokio runtime thread.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mention this is due to limitation from the reqwest crate, and not a restriction imposed by us?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets improve this based on any feedback we get. I am neutral about this currently, since we talk about supported features flags in general, without talking about why something is not supported.

@cijothomas cijothomas merged commit acaa98d into open-telemetry:main Jan 22, 2025
21 checks passed
@cijothomas cijothomas deleted the cijothomas/simplelog-doc branch January 22, 2025 18:15
@ratijas
Copy link

ratijas commented Jul 25, 2025

This is actually so very well hidden, considering that scattered examples mostly use builder method with_simple_exporter which doesn't really expose the issue with SimpleSpanProcessor; so you have to find this thing among the docs, or read through the source code

@ratijas
Copy link

ratijas commented Jul 25, 2025

Also, what exactly does this mean?

The following feature flags offer additional configurations on http:

As far as my reverse-engineering skills go, these feature flags offer no configuration. In fact, it's just a big if { #[cfg(...)] #[cfg(...)] #[cfg(...)] } in another crate which will kinda panic if you got the cfg part wrong. Which you will get wrong on the first try, because you forgot to remove default-features before adding the right flavor of client. AFAICT nothing mentions those client features are supposed to be mutually exclusive either. You will get it wrong on the second try too, because you just broke the build, so now you have to add all the default features back one by one — all but the "reqwest-blocking-client" obviously. Phew…

…and after all that setup, it just hang up at
DEBUG reqwest::connect > starting new connection: http://localhost:4318/
not even able to be interrupted by Ctrl+C.

Something isn't so Simple about this Simple processor, huh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SimpleExporter is not useable with OTLP/Http

3 participants