-
Notifications
You must be signed in to change notification settings - Fork 599
Doc additions for Simple and Batch processors #2529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
52781ef
4991ff3
76e6940
df6489a
643b1f6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -104,7 +104,18 @@ pub trait LogProcessor: Send + Sync + Debug { | |
| } | ||
|
|
||
| /// A [`LogProcessor`] designed for testing and debugging purpose, that immediately | ||
| /// exports log records as they are emitted. | ||
| /// exports log records as they are emitted. Log records are exported synchronously | ||
| /// in the same thread that emits the log record. | ||
| /// When using this processor with the OTLP Exporter, the following exporter | ||
| /// features are supported: | ||
| /// - `grpc-tonic`: This requires LoggerProvider to be created within a tokio | ||
| /// runtime. Logs can emitted from any thread, including tokio runtime | ||
| /// threads. | ||
| /// - `reqwest-blocking-client`: LoggerProvider may be created anywhere, but | ||
| /// logs must be emitted from a non-tokio runtime thread. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should we mention this is due to limitation from the reqwest crate, and not a restriction imposed by us?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lets improve this based on any feedback we get. I am neutral about this currently, since we talk about supported features flags in general, without talking about why something is not supported. |
||
| /// - `reqwest-client`: LoggerProvider may be created anywhere, but logs must be | ||
| /// emitted from a tokio runtime thread. | ||
| /// | ||
| /// ## Example | ||
| /// | ||
| /// ### Using a SimpleLogProcessor | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.