Skip to content

Conversation

@cijothomas
Copy link
Member

Continuing from #2604
In another small follow up, I should be able to remove pub enum MetricError completely!

@cijothomas cijothomas requested a review from a team as a code owner April 6, 2025 16:53
@codecov
Copy link

codecov bot commented Apr 6, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.3%. Comparing base (e9ae9f9) to head (8b076e8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/manual_reader.rs 0.0% 6 Missing ⚠️
.../src/metrics/periodic_reader_with_async_runtime.rs 90.0% 1 Missing ⚠️
...telemetry-sdk/src/testing/metrics/metric_reader.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2905     +/-   ##
=======================================
- Coverage   81.3%   81.3%   -0.1%     
=======================================
  Files        126     126             
  Lines      24143   24156     +13     
=======================================
+ Hits       19639   19649     +10     
- Misses      4504    4507      +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas added the semver-check For PRs that need to run semver compliance checks label Apr 6, 2025
Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@cijothomas cijothomas merged commit bc82d4f into open-telemetry:main Apr 6, 2025
24 of 26 checks passed
@cijothomas cijothomas deleted the cijothomas/metric-error-cleanup branch April 6, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-check For PRs that need to run semver compliance checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants