-
Notifications
You must be signed in to change notification settings - Fork 600
feat: Use builder pattern for constructing Metric Streams #2984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use builder pattern for constructing Metric Streams #2984
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
=======================================
+ Coverage 81.1% 81.3% +0.2%
=======================================
Files 126 126
Lines 24558 24634 +76
=======================================
+ Hits 19918 20042 +124
+ Misses 4640 4592 -48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scottgerring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; uncontroversial improvement to the metrics API
Continuing #2982
Fixed #1414