Skip to content

Conversation

@cijothomas
Copy link
Member

@cijothomas cijothomas commented May 21, 2025

Continuing #2982

Fixed #1414

@cijothomas cijothomas requested a review from a team as a code owner May 21, 2025 06:12
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 88.59649% with 13 lines in your changes missing coverage. Please review.

Project coverage is 81.3%. Comparing base (aeb38a0) to head (ef59e04).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/mod.rs 88.3% 7 Missing ⚠️
opentelemetry-sdk/src/metrics/instrument.rs 88.0% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2984     +/-   ##
=======================================
+ Coverage   81.1%   81.3%   +0.2%     
=======================================
  Files        126     126             
  Lines      24558   24634     +76     
=======================================
+ Hits       19918   20042    +124     
+ Misses      4640    4592     -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; uncontroversial improvement to the metrics API

@cijothomas cijothomas merged commit f04e9ec into open-telemetry:main May 21, 2025
27 checks passed
@cijothomas cijothomas deleted the cijothomas/view-stream-fix branch May 21, 2025 14:37
@cijothomas cijothomas mentioned this pull request May 21, 2025
@cijothomas cijothomas mentioned this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: View validations to be moved elsewhere

3 participants