Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2985
Continuing from #2984 and #2982
This removes the
new_viewway of creating a View. Instead users are expected to pass anything implementingViewtrait. For convenience,Viewis implemented forFn(&Instrument) -> Option<Stream>, so this can be used to add a view.This allowed a lot of other cleanups. If there is a need, more additive changes can be done to make it easier to apply view for the common scenario.
Example of future additions (not part of this PR!):