Skip to content

Conversation

@cijothomas
Copy link
Member

Show the recommended option in the doc, instead of showing simple_exporter and then telling few lines down that it is not recommended! All examples of OTLP are already using batch-exporter only.

Keeping simple_exporter to truly getting-started guides, that uses stdout is better.

@cijothomas cijothomas requested a review from a team as a code owner August 2, 2025 02:29
@cijothomas cijothomas requested a review from Copilot August 2, 2025 02:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the OpenTelemetry OTLP documentation to show best practices by default, replacing with_simple_exporter with with_batch_exporter in all code examples and removing a redundant performance section that explained why batch exporters are preferred.

  • Updated three code examples to use with_batch_exporter instead of with_simple_exporter
  • Removed the "Performance" section that contained redundant information about batch vs simple exporters

@codecov
Copy link

codecov bot commented Aug 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.5%. Comparing base (4486207) to head (e2e7a5a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3105     +/-   ##
=======================================
- Coverage   80.5%   80.5%   -0.1%     
=======================================
  Files        126     126             
  Lines      22218   22218             
=======================================
- Hits       17890   17889      -1     
- Misses      4328    4329      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas changed the title docs : Don't unnecessarily show simpleexporter in OTLP docs docs: Don't unnecessarily show simpleexporter in OTLP docs Aug 2, 2025
@cijothomas cijothomas merged commit 097dab9 into open-telemetry:main Aug 4, 2025
27 checks passed
@cijothomas cijothomas deleted the cijothomas/otlp-batch-doc branch August 4, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants