-
Notifications
You must be signed in to change notification settings - Fork 931
Add severity-based and trace-based log record processors #4611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add severity-based and trace-based log record processors #4611
Conversation
ca86d92
to
a5e39f1
Compare
specification/logs/sdk.md
Outdated
and return `true` if not available. | ||
* [`OnEmit`](#onemit) - If the log record is associated with a valid span | ||
context that is not sampled, MUST NOT forward it to the delegate. Otherwise, MUST | ||
forward the log record to the delegate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Could we update the desc of this to make it more obvious that if the log is emitted outside any active spans, then they are not subject to filtering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewrote, ptal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Waiting to undraft!
7dc4d37
to
f0f47fa
Compare
Based on discussion in today's spec SIG meeting, I am going to proceed with #4612 instead |
See alternative in #4612
Some related prior discussions:
Java POC @ open-telemetry/opentelemetry-java#7520
Here's an example of how it would look like to use both of these in declarative configuration: