pprof: add profile attribute #3078
Open
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pprof specific attributes to help convert pprof to OTel profiles and vice versa. Signed-off-by: Florian Lehner <[email protected]>
florianl
force-pushed
the
pprof-profile
branch
from
ffbafc0 to
27ddb08
Compare
florianl
commented
Nov 13, 2025
| examples: | ||
| - "/foobar/" | ||
| stability: development | ||
| - id: pprof.profile.keep_frames |
Contributor
Author
There was a problem hiding this comment.
florianl
commented
Nov 13, 2025
| examples: | ||
| - ["hello world", "bazinga"] | ||
| stability: development | ||
| - id: pprof.profile.drop_frames |
Contributor
Author
There was a problem hiding this comment.
florianl
commented
Nov 13, 2025
| examples: | ||
| - "/bazinga/" | ||
| stability: development | ||
| - id: pprof.profile.doc_url |
Contributor
Author
There was a problem hiding this comment.
florianl
commented
Nov 13, 2025
| examples: | ||
| - "http://pprof.example.com/cpu-profile.html" | ||
| stability: development | ||
| - id: pprof.profile.default_sample_type |
Contributor
Author
There was a problem hiding this comment.
florianl
moved this from Untriaged
to Awaiting codeowners approval
in Semantic Conventions Triage
christos68k
reviewed
Nov 13, 2025
Contributor
|
Should these new attributes also appear on the profiles page in the compatibility section? |
Signed-off-by: Florian Lehner <[email protected]>
aalexand
reviewed
Nov 26, 2025
| | [`pprof.mapping.has_inline_frames`](/docs/registry/attributes/pprof.md) |  | `Recommended` | boolean | Indicates that there are inline frames related to this mapping. | | | ||
| | [`pprof.mapping.has_line_numbers`](/docs/registry/attributes/pprof.md) |  | `Recommended` | boolean | Indicates that there are line numbers related to this mapping. | | | ||
| | [`pprof.profile.comment`](/docs/registry/attributes/pprof.md) |  | `Recommended` | string[] | Free-form text associated with the profile. This field should not be used to store any machine-readable information, it is only for human-friendly content. | `["hello world", "bazinga"]` | | ||
| | [`pprof.profile.default_sample_type`](/docs/registry/attributes/pprof.md) |  | `Recommended` | string | Type of the preferred sample value. | `cpu` | |
Member
There was a problem hiding this comment.
What attributes map will carry this attribute? Instrumentation scope?
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add pprof specific attributes to help convert pprof to OTel profiles and vice versa.
FYI @open-telemetry/profiling-approvers
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]