-
Notifications
You must be signed in to change notification settings - Fork 282
pprof: add profile attribute #3078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: 'enhancement' | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: pprof | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: add various pprof attributes to support lossless conversion from and to OTel profiles. | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [3078] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,3 +44,36 @@ groups: | |
| examples: | ||
| - ["hello world", "bazinga"] | ||
| stability: development | ||
| - id: pprof.profile.drop_frames | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| brief: > | ||
| Frames with Function.function_name fully matching the regexp will be | ||
| dropped from the samples, along with their successors. | ||
| type: string | ||
| examples: | ||
| - "/foobar/" | ||
| stability: development | ||
| - id: pprof.profile.keep_frames | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| brief: > | ||
| Frames with Function.function_name fully matching the regexp will be | ||
| kept, even if it matches drop_frames. | ||
| type: string | ||
| examples: | ||
| - "/bazinga/" | ||
| stability: development | ||
| - id: pprof.profile.doc_url | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| brief: > | ||
| Documentation link for this profile type. | ||
| type: string | ||
| note: > | ||
| The URL must be absolute and may be missing if the profile was | ||
| generated by code that did not supply a link | ||
| examples: | ||
| - "http://pprof.example.com/cpu-profile.html" | ||
| stability: development | ||
| - id: pprof.profile.default_sample_type | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| brief: > | ||
| Type of the preferred sample value. | ||
| type: string | ||
| examples: | ||
| - "cpu" | ||
| stability: development | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What attributes map will carry this attribute? Instrumentation scope?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ResourceProfiles.resource.attributes might be the best location to set this attribute.