LOG: Add BT_LOGV to print verbose log. #290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuX10
approved these changes
Nov 19, 2025
gzh-terry
reviewed
Nov 19, 2025
chengkai15
reviewed
Nov 19, 2025
gzh-terry
approved these changes
Nov 21, 2025
chengkai15
previously approved these changes
Nov 21, 2025
expliyh
force-pushed
the
verbose_log
branch
2 times, most recently
from
5bb980e to
e902530
Compare
expliyh
force-pushed
the
verbose_log
branch
2 times, most recently
from
99ea4ef to
69b94a5
Compare
gzh-terry
approved these changes
Dec 22, 2025
| if (bt_log_print_check(BT_LOG_LEVEL_DEBUG)) \ | ||
| BT_LOG(LOG_ID_FRAMEWORK, BT_LOG_LEVEL_DEBUG, fmt, ##__VA_ARGS__); \ | ||
| } while (0); | ||
| #if CONFIG_BLUETOOTH_SERVICE_LOG_LEVEL < 7 |
There was a problem hiding this comment.
Here is #if CONFIG_BLUETOOTH_SERVICE_LOG_LEVEL <= 7 or #if CONFIG_BLUETOOTH_SERVICE_LOG_LEVEL < 8?
liuX10
approved these changes
Dec 23, 2025
chengkai15
reviewed
Dec 23, 2025
| BT_LOG(LOG_ID_FRAMEWORK, BT_LOG_LEVEL_DEBUG, fmt, ##__VA_ARGS__); \ | ||
| } while (0); | ||
| #if CONFIG_BLUETOOTH_SERVICE_LOG_LEVEL < 7 | ||
| #define BT_LOGV(fmt, args...) |
Contributor
There was a problem hiding this comment.
could we handle the case like BT_LOGD？ as LINE:55 code does
Contributor
Author
There was a problem hiding this comment.
No, it would create too many conditional branches in production, slowing down the system.
expliyh
force-pushed
the
verbose_log
branch
2 times, most recently
from
be31cfb to
431a756
Compare
bug: v/78468 Signed-off-by: YuhengLi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: v/78468