Skip to content

LOG: Add BT_LOGV to print verbose log. #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
expliyh wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

LOG: Add BT_LOGV to print verbose log. #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,7 @@ config BLUETOOTH_SERVICE_LOG_LEVEL
default 7
depends on BLUETOOTH_SERVICE
help
Set BT Service log level <0~7>
Set BT Service log level <0~8>
endif #BLUETOOTH_LOG

endmenu #Debug
Expand Down
11 changes: 11 additions & 0 deletions service/utils/log.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ enum bt_log_level_ {
BT_LOG_LEVEL_WARNING = LOG_WARNING,
BT_LOG_LEVEL_INFO = LOG_INFO,
BT_LOG_LEVEL_DEBUG = LOG_DEBUG,
BT_LOG_LEVEL_VERBOSE,
};

#ifndef CONFIG_BLUETOOTH_SERVICE_LOG_LEVEL
Expand All @@ -51,6 +52,7 @@ enum bt_log_level_ {
#define BT_LOGW(fmt, args...)
#define BT_LOGI(fmt, args...)
#define BT_LOGD(fmt, args...)
#define BT_LOGV(fmt, args...)
#else
extern bool bt_log_print_check(uint8_t level);

Expand Down Expand Up @@ -81,6 +83,15 @@ extern bool bt_log_print_check(uint8_t level);
if (bt_log_print_check(BT_LOG_LEVEL_DEBUG)) \
BT_LOG(LOG_ID_FRAMEWORK, BT_LOG_LEVEL_DEBUG, fmt, ##__VA_ARGS__); \
} while (0);
#if CONFIG_BLUETOOTH_SERVICE_LOG_LEVEL < 7
Copy link

@huangyulong3 huangyulong3 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is #if CONFIG_BLUETOOTH_SERVICE_LOG_LEVEL <= 7 or #if CONFIG_BLUETOOTH_SERVICE_LOG_LEVEL < 8?

#define BT_LOGV(fmt, args...)
Copy link
Contributor

@chengkai15 chengkai15 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we handle the case like BT_LOGD？ as LINE:55 code does

Copy link
Contributor Author

@expliyh expliyh Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it would create too many conditional branches in production, slowing down the system.

#else
#define BT_LOGV(fmt, ...) \
do { \
if (bt_log_print_check(BT_LOG_LEVEL_VERBOSE)) \
BT_LOG(LOG_ID_FRAMEWORK, BT_LOG_LEVEL_DEBUG, fmt, ##__VA_ARGS__); \
} while (0);
#endif
#endif

#define BT_ADDR_LOG(fmt, _addr, ...) \
Expand Down
Loading