zblue: spp: unregister rfcomm server when sdp register fails#463
Open
expliyh wants to merge 1 commit intoopen-vela:devfrom
Open
zblue: spp: unregister rfcomm server when sdp register fails#463expliyh wants to merge 1 commit intoopen-vela:devfrom
expliyh wants to merge 1 commit intoopen-vela:devfrom
Conversation
bug: v/86062 Rootcause: not unregister rfcomm server when sdp register fails causing memory access after free Signed-off-by: YuhengLi <liyuheng@xiaomi.com>
expliyh
requested review from
chengkai15,
gzh-terry,
huangyulong3,
hyson710,
zhangyuan376 and
zhongzhijie1
as code owners
| ret = bt_sdp_register_service(server->sdp_record); | ||
| if (ret < 0) { | ||
| // TODO: unregister rfcomm server | ||
| BT_LOGE("Failed to register SDP record: %d", ret); |
Contributor
There was a problem hiding this comment.
Check if it has run to this point.
zhangyuan376
approved these changes
Feb 13, 2026
chengkai15
reviewed
Feb 13, 2026
| if (ret < 0) { | ||
| // TODO: unregister rfcomm server | ||
| BT_LOGE("Failed to register SDP record: %d", ret); | ||
| bt_rfcomm_server_unregister(&server->rfcomm_server); |
Contributor
There was a problem hiding this comment.
and here could fix it when it register fail.
could we find the rootcause why bt_sdp_register_service fail?
it seem to forget free it last time
gzh-terry
reviewed
Feb 14, 2026
gzh-terry
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug: v/86062
Rootcause: not unregister rfcomm server when sdp register fails causing memory access after free