Skip to content

zblue: spp: unregister rfcomm server when sdp register fails #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
expliyh wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

zblue: spp: unregister rfcomm server when sdp register fails #463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service/stacks/zephyr/sal_spp_interface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,8 +659,8 @@ bt_status_t bt_sal_spp_server_start(uint16_t port, bt_uuid_t* uuid, uint8_t max_
server->sdp_record = (struct bt_sdp_record*)spp_sdp_create_record(scn, uuid);
ret = bt_sdp_register_service(server->sdp_record);
if (ret < 0) {
// TODO: unregister rfcomm server
BT_LOGE("Failed to register SDP record: %d", ret);
Copy link
Contributor

@zhangyuan376 zhangyuan376 Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if it has run to this point.

bt_rfcomm_server_unregister(&server->rfcomm_server);
Copy link
Contributor

@chengkai15 chengkai15 Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here could fix it when it register fail.

could we find the rootcause why bt_sdp_register_service fail?

it seem to forget free it last time

spp_sdp_remove_record(server->sdp_record);
free(server);
return BT_STATUS_FAIL;
Expand Down
Loading