Fixed parsing reaction conditions without parentheses #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eepMoody
approved these changes
Dec 30, 2025
Collaborator
eepMoody
left a comment
eepMoody
left a comment
There was a problem hiding this comment.
Thanks for this, nice catch!
eepMoody
added a commit
that referenced
this pull request
Dec 31, 2025
calumbell
pushed a commit
that referenced
this pull request
Jan 1, 2026
* Fix spell data regressions from PR #842 and update newrelic API * add missing higher-leve options * add tests for duplicate or missing higher_level values * Add missing casting options for deepm and spells-that-dont-suck * fix freezing sphere being merged with freedom of movement
calumbell
pushed a commit
that referenced
this pull request
Jan 1, 2026
* Fix spell data regressions from PR #842 and update newrelic API * add missing higher-leve options * add tests for duplicate or missing higher_level values * Add missing casting options for deepm and spells-that-dont-suck * fix freezing sphere being merged with freedom of movement * convert ambiguously precise fields to integers * update test cases to reflect integers * update decimal speed fallbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many spells like Shield and Feather Fall which have a reaction were missing the conditions of the reaction. I wasn't smart enough to write one regex to rule them all. What I ended up doing was checking if the first regex failed and if so searching again without looking for parentheses and also allowing for an optional comma.
This could probably use some sort of fancy diff on the resulting JSON file to make sure nothing got screwed up. But I did confirm that some spells that were missing the reaction condition before now have them.