Skip to content

Conversation

@eepMoody
Copy link
Collaborator

@eepMoody eepMoody commented Dec 31, 2025

Summary

Fixes data regressions introduced by PR #842 and adds validation tests for spell casting options.

Closes #753

Changes

Data Fixes (SRD-2024)

  • Restored higher_level for Fireball
  • Restored component fields for Barkskin and Guidance
  • Restored full descriptions for Wish, Antipathy/Sympathy, and Command
  • Removed "### X Spells" parsing artifacts from 10 spell descriptions

New Casting Options

  • Added casting options for deepm_anchoring-rope-reaction (5 options)
  • Created SpellCastingOption.json for spells-that-dont-suck with 60 options covering:
    • adaptation, animal-ally, animal-transformation, arctic-breath
    • aura-of-concealment, aura-of-truth, befriend-beast, bewilder

Tests

  • Added TestSpellCastingOptions class with two validation tests:
    • All spells with higher_level text must have casting options
    • No spell may have duplicate casting option types

Infrastructure

  • Updated NewRelic middleware to use add_custom_attribute (API change)

Note

Strengthens spell data integrity and fixes a content issue.

  • Adds TestSpellCastingOptions with checks that spells with higher_level have casting_options and that no duplicate casting_options.type exist via /v2/spells responses
  • Corrects SRD markdown by changing the "Freezing Sphere" section header to #### Freezing Sphere in 08_b_spellsaz.md

Written by Cursor Bugbot for commit 61a5992. This will update automatically on new commits. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@eepMoody eepMoody changed the title Fix spell data regressions from PR #842 Fix spell data regressions and omissions Dec 31, 2025
@eepMoody eepMoody force-pushed the fix/spell-data-regressions-pr842 branch from d10b4e0 to 61a5992 Compare December 31, 2025 18:06
@open5e open5e deleted a comment from cursor bot Jan 1, 2026
Copy link
Contributor

@calumbell calumbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, good job spotting these errors.

The PR is too large for me to realistically investigate the JSON line-by-line, so I am leaning on pytest and spot checking on a local Django server. A cursory glance reveals that everything is looking good. The Python looks fine to me, it is clear what every part is doing and it fits established style conventions.

I am happy to get this approved :)

@calumbell calumbell merged commit 28da537 into staging Jan 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TODO] Add "at higher levels" array to 2024 spells

3 participants