refactor: add GlobalsAccessor abstraction for OpenEMR globals access #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ConfigAccessorInterface with typed getters (get, getString, getBoolean, getInt, has) - Implement GlobalsAccessor to wrap $GLOBALS access - Update CodeImporter to use injected ConfigAccessorInterface - Update OpenEMRConnector to use injected ConfigAccessorInterface - Update ImportCodesCommand to wire up GlobalsAccessor by default - Add comprehensive unit tests for GlobalsAccessor (21 tests) - Update existing tests for new constructor signatures Fixes #19 Co-Authored-By: Claude Opus 4.5 <[email protected]>
kojiromike
force-pushed
the
globalsaccessor
branch
from
9cdf22b to
281b9e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ConfigAccessorInterfacewith typed getters (get,getString,getBoolean,getInt,has)GlobalsAccessorclass to centralize$GLOBALSaccessFixes #19
Test plan
🤖 Generated with Claude Code