Skip to content

Migrate .js.erb files to .js#2059

Merged
MrSerth merged 1 commit intomainfrom
ss/migrate_js_erb_to_js
Jul 4, 2025
Merged

Migrate .js.erb files to .js#2059
MrSerth merged 1 commit intomainfrom
ss/migrate_js_erb_to_js

Conversation

@MrSerth
Copy link
Member

@MrSerth MrSerth commented Jul 2, 2025

We want to get rid of .js.erb files, and hence migrate them to regular JavaScript files. Required attributes are passed through data-attributes in the HTML.

@MrSerth MrSerth self-assigned this Jul 2, 2025
@MrSerth MrSerth added enhancement javascript Pull requests that update Javascript code labels Jul 2, 2025
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.74%. Comparing base (5dc4094) to head (533c8be).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2059      +/-   ##
==========================================
- Coverage   94.85%   94.74%   -0.12%     
==========================================
  Files         133      133              
  Lines        3385     3385              
==========================================
- Hits         3211     3207       -4     
- Misses        174      178       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrSerth MrSerth merged commit 1bfd28c into main Jul 4, 2025
10 checks passed
@MrSerth MrSerth deleted the ss/migrate_js_erb_to_js branch July 4, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments