Replace mifos-passcode with new version from mifor-wallet/libs/mifos-passcode #65
Conversation
niyajali
left a comment
niyajali
left a comment
There was a problem hiding this comment.
@meetjain6091 Include .kotlin directory on .gitignore and remove that directly from this PR, and do other changes and let us know we'll review it again.
| implementation(project(":core:data")) | ||
|
|
||
| implementation(libs.findLibrary("jb.composeRuntime").get()) | ||
| implementation(libs.findLibrary("jb.composeViewmodel").get()) |
There was a problem hiding this comment.
Include these dependencies like above for e.g
implementation(libs.jb.composeRuntime) check their name version catalog (libs.version.toml)
| } | ||
|
|
||
| // Setup protobuf configuration, generating lite Java and Kotlin classes | ||
| protobuf { |
There was a problem hiding this comment.
Remove this protobuf block of code, not required
| implementation(libs.multiplatform.settings.coroutines) | ||
|
|
||
| implementation(libs.kotlinx.coroutines.core) | ||
| implementation(libs.kotlinx.serialization.core) |
There was a problem hiding this comment.
@meetjain6091 what ever dependency you added below implementation(libs.kotlinx.serialization.core) is not neccessary because all of them are already added in the CMPFeatureConventionPlugin
There was a problem hiding this comment.
@HekmatullahAmin We don't have that plugin in this repo and we have to configure build-logic here which is lot of works and that's not necessary since it requires few dependencies .
That's why we're recommended him to manually include those dependencies directly on library Gradle file.
|
@meetjain6091 I shared a video on how to add plugins and dependencies in mifos-passcode slack channel. go there and follow it. |
|
Thankyou brother, I will refer the video and finish the task
…On Wed, 12 Mar, 2025, 15:55 Hekmatullah, ***@***.***> wrote:
@meetjain6091 <https://github.com/meetjain6091> I shared a video on how
to add plugins and dependencies in mifos-passcode slack channel. go there
and follow it.
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNJUMJ2BRKOPJKFBXFZJ6YL2UADRNAVCNFSM6AAAAABYWS66VSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJXGM4DINBXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: HekmatullahAmin]*HekmatullahAmin* left a comment
(openMF/mifos-passcode#65)
<#65 (comment)>
@meetjain6091 <https://github.com/meetjain6091> I shared a video on how
to add plugins and dependencies in mifos-passcode slack channel. go there
and follow it.
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNJUMJ2BRKOPJKFBXFZJ6YL2UADRNAVCNFSM6AAAAABYWS66VSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJXGM4DINBXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
4 participants
I was working on replacing mifos-passcode/mifos-passcode to mifos-wallet/libs/mifos-passcode i added almost all library but this
mifospay-cmp-feature = { id = "mifospay.cmp.feature", version = "unspecified" }
is connected to other module called build-logic now how to proceed can u please guide me I have already added the dependencies from the plugin (CMPFeature plugin) and pasted it on mifos-passcode Gradle file