This repository was archived by the owner on Apr 29, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Replace mifos-passcode with new version from mifor-wallet/libs/mifos-passcode #65
Open
meetjain6091
wants to merge
2
commits into
openMF:master
Choose a base branch
from
meetjain6091:replace-mifos-passcode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ | |
| *.class | ||
|
|
||
| # Generated files | ||
| .kotlin/ | ||
| bin/ | ||
| gen/ | ||
| out/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| /build | ||
| /build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # :feature:passcode module | ||
| ## Dependency graph | ||
|  | ||
| # :libs:mifos-passcode module | ||
| ## Dependency graph | ||
|  |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| /* | ||
| * Copyright 2024 Mifos Initiative | ||
| * | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
| * | ||
| * See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md | ||
| */ | ||
| plugins { | ||
| alias(libs.plugins.mifospay.cmp.feature) | ||
| alias(libs.plugins.kotlin.parcelize) | ||
| alias(libs.plugins.kotlin.serialization) | ||
| alias(libs.plugins.protobuf) | ||
| } | ||
|
|
||
| android { | ||
| namespace = "com.mifos.library.passcode" | ||
| } | ||
|
|
||
| kotlin { | ||
| sourceSets { | ||
| commonMain.dependencies { | ||
| implementation(compose.ui) | ||
| implementation(compose.foundation) | ||
| implementation(compose.material3) | ||
| implementation(compose.materialIconsExtended) | ||
| implementation(compose.components.resources) | ||
| implementation(compose.components.uiToolingPreview) | ||
|
|
||
| implementation(libs.koin.compose.viewmodel) | ||
| implementation(libs.koin.compose) | ||
|
|
||
| implementation(libs.jb.kotlin.stdlib) | ||
| implementation(libs.kotlin.reflect) | ||
|
|
||
| api(libs.protobuf.kotlin.lite) | ||
| implementation(libs.kotlinx.serialization.core) | ||
|
|
||
| implementation(libs.multiplatform.settings) | ||
| implementation(libs.multiplatform.settings.serialization) | ||
| implementation(libs.multiplatform.settings.coroutines) | ||
|
|
||
| implementation(libs.kotlinx.coroutines.core) | ||
| implementation(libs.kotlinx.serialization.core) | ||
|
|
||
| implementation(project(":core:ui")) | ||
| implementation(project(":core:designsystem")) | ||
| implementation(project(":core:data")) | ||
|
|
||
| implementation(libs.findLibrary("jb.composeRuntime").get()) | ||
| implementation(libs.findLibrary("jb.composeViewmodel").get()) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Include these dependencies like above for e.g |
||
| implementation(libs.findLibrary("jb.lifecycleViewmodel").get()) | ||
| implementation(libs.findLibrary("jb.lifecycleViewmodelSavedState").get()) | ||
| implementation(libs.findLibrary("jb.savedstate").get()) | ||
| implementation(libs.findLibrary("jb.bundle").get()) | ||
| implementation(libs.findLibrary("jb.composeNavigation").get()) | ||
| implementation(libs.findLibrary("kotlinx.collections.immutable").get()) | ||
| } | ||
|
|
||
| androidMain.dependencies { | ||
| implementation(libs.findLibrary("androidx.lifecycle.runtimeCompose").get()) | ||
| implementation(libs.findLibrary("androidx.lifecycle.viewModelCompose").get()) | ||
| implementation(libs.findLibrary("androidx.tracing.ktx").get()) | ||
|
|
||
| implementation(platform(libs.findLibrary("koin-bom").get())) | ||
| implementation(libs.findLibrary("koin-android").get()) | ||
| implementation(libs.findLibrary("koin.androidx.compose").get()) | ||
| implementation(libs.findLibrary("koin.android").get()) | ||
| implementation(libs.findLibrary("koin.androidx.navigation").get()) | ||
| implementation(libs.findLibrary("koin.androidx.compose").get()) | ||
| implementation(libs.findLibrary("koin.core.viewmodel").get()) | ||
| } | ||
|
|
||
| androidInstrumentedTest.dependencies { | ||
| implementation(libs.findLibrary("androidx.navigation.testing").get()) | ||
| implementation(libs.findLibrary("androidx.compose.ui.test").get()) | ||
| implementation(libs.findLibrary("androidx.lifecycle.runtimeTesting").get()) | ||
| } | ||
|
|
||
| androidTest.dependencies { | ||
| implementation(libs.findLibrary("koin.test.junit4").get()) | ||
| } | ||
|
|
||
| desktopMain.dependencies { | ||
| implementation(libs.kotlinx.coroutines.swing) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Setup protobuf configuration, generating lite Java and Kotlin classes | ||
| protobuf { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove this protobuf block of code, not required |
||
| protoc { | ||
| artifact = libs.protobuf.protoc.get().toString() | ||
| } | ||
| generateProtoTasks { | ||
| all().forEach { task -> | ||
| task.builtins { | ||
| register("kotlin") { | ||
| option("lite") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- | ||
| Copyright 2024 Mifos Initiative | ||
|
|
||
| This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. | ||
| If a copy of the MPL was not distributed with this file, | ||
| You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
|
||
| See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md | ||
| --> | ||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <uses-permission android:name="android.permission.VIBRATE" /> | ||
| </manifest> |
Binary file added
BIN
+73.9 KB
...code/src/commonMain/composeResources/drawable/lib_mifos_passcode_mifos_logo.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+67.9 KB
mifos-passcode/src/commonMain/composeResources/font/lib_mifos_passcode_lato_black.ttf
Binary file not shown.
Binary file added
BIN
+71.6 KB
mifos-passcode/src/commonMain/composeResources/font/lib_mifos_passcode_lato_bold.ttf
Binary file not shown.
Binary file added
BIN
+73.4 KB
mifos-passcode/src/commonMain/composeResources/font/lib_mifos_passcode_lato_regular.ttf
Binary file not shown.
34 changes: 34 additions & 0 deletions
34
mifos-passcode/src/commonMain/composeResources/values/strings.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <!-- | ||
| Copyright 2024 Mifos Initiative | ||
|
|
||
| This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. | ||
| If a copy of the MPL was not distributed with this file, | ||
| You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
|
||
| See https://github.com/openMF/mobile-wallet/blob/master/LICENSE.md | ||
| --> | ||
| <resources> | ||
| <string name="lib_mifos_passcode_title">Passcode will be reset, are you sure?</string> | ||
| <string name="lib_mifos_passcode_cancel">Cancel</string> | ||
| <string name="lib_mifos_passcode_yes">Yes</string> | ||
| <string name="lib_mifos_passcode_pref_name">Passcode</string> | ||
| <string name="lib_mifos_passcode_has_passcode">hasPasscode</string> | ||
| <string name="lib_mifos_passcode_has_drag_passcode">hasDragPasscode</string> | ||
| <string name="lib_mifos_passcode">passcode</string> | ||
| <string name="lib_mifos_passcode_drag_passcode">drag_passcode</string> | ||
|
|
||
| <string name="library_mifos_passcode_create_passcode">Create Passcode</string> | ||
| <string name="library_mifos_passcode_confirm_passcode">Confirm Passcode</string> | ||
| <string name="library_mifos_passcode_enter_your_passcode">Enter your Passcode</string> | ||
| <string name="library_mifos_passcode_forgot_passcode">Forgot Passcode</string> | ||
| <string name="library_mifos_passcode_delete_passcode">Delete Passcode Key Button</string> | ||
| <string name="library_mifos_passcode_drag_guide">Drag your finger here only in one direction.</string> | ||
| <string name="library_mifos_passcode_drag_your_pattern">Drag your Pattern</string> | ||
| <string name="library_mifos_passcode_exit">Exit</string> | ||
| <string name="library_mifos_passcode_skip">Skip</string> | ||
| <string name="library_mifos_passcode_login_manually">Forgot Passcode, Login Manually</string> | ||
| <string name="library_mifos_passcode_try_again">Try again</string> | ||
| <string name="library_mifos_passcode_do_not_match">Passcode do not match!</string> | ||
| <string name="library_mifos_passcode_exit_message">Are you sure you want to exit?</string> | ||
| </resources> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meetjain6091 what ever dependency you added below
implementation(libs.kotlinx.serialization.core)is not neccessary because all of them are already added in theCMPFeatureConventionPluginThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HekmatullahAmin We don't have that plugin in this repo and we have to configure build-logic here which is lot of works and that's not necessary since it requires few dependencies .
That's why we're recommended him to manually include those dependencies directly on library Gradle file.