-
Notifications
You must be signed in to change notification settings - Fork 6.4k
refactor sandboxing (1/?) #7045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let sandboxed = !matches!( | ||
| &effective_policy, | ||
| codex_core::protocol::SandboxPolicy::DangerFullAccess | ||
| ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Respect platform sandbox availability
This new sandboxed flag ignores whether the current platform actually has a sandbox. In production we use get_platform_has_sandbox() (see core/src/safety.rs) to track e.g. the experimental Windows sandbox, and previously this code called get_platform_sandbox() to fall back to SandboxType::None when it was disabled. Now we always pass sandboxed = true for any policy that isn’t DangerFullAccess, so on Windows without the sandbox enabled we will still route through exec_windows_sandbox (see core/src/exec.rs around the new if sandboxed { return exec_windows_sandbox(...) }). That configuration is common, and those calls will start failing instead of running unsandboxed. Please gate this bool on get_platform_has_sandbox() the same way we did before.
Useful? React with 👍 / 👎.
The sandboxing code has been getting a bit twisty. This is the first step of ??? to iron it out.