Assistant - Fix null-reference exception when accessing RunStepDetailsUpdate.FunctionName
#293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
changed the title
RunStepDetailsUpdate.FunctionNameRunStepDetailsUpdate.FunctionName
4 tasks
joseharriaga
approved these changes
Nov 18, 2024
Collaborator
|
Thank you for your contribution, @crickman ! |
github-merge-queue bot
pushed a commit
to microsoft/semantic-kernel
that referenced
this pull request
Nov 19, 2024
…h result when streaming (#9742) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Fixes: #9723 Must distinguish between file-search result and function-call result for assistant streaming without triggering `NullReferenceException` ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> A file-search result provide any streaming result; rather, it results in an annotation on the assistant message. Still it must be distinguished from a function-call result. Since `RunStepDetailsUpdate.FunctionName` property throws a `NullReferenceException` when being evaluated, using `RunStepDetailsUpdate.FunctionResult` property. Merged fix to Open AI SDK: openai/openai-dotnet#293 ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Sep 29, 2025
This was referenced Oct 13, 2025
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The propertis for
RunStepDetailsUpdateall fall-through for null internal definitions, except forFunctionName...which results in aNullReferenceException. This is inconsistent with the expected behavior.This complicates inspection when file-search and functions are both enabled.