Skip to content

improve performance of BinaryData construction #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

improve performance of BinaryData construction #570

merged 1 commit into from
Jul 30, 2025

Conversation

@christothes
Copy link
Collaborator

@christothes christothes commented Jul 30, 2025

Avoids using stream.ToArray() in favor of ReadOnlyMemory.

Method Mean Error StdDev Ratio Gen0 Gen1 Allocated Alloc Ratio
ToArray 4.029 us 0.0377 us 0.0334 us 1.00 2.9984 0.1831 24.53 KB 1.00
ROM 3.818 us 0.0177 us 0.0148 us 0.95 2.4033 0.0839 19.66 KB 0.80

@christothes christothes merged commit 3907f7b into openai:main Jul 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KrzysztofCwalina KrzysztofCwalina KrzysztofCwalina approved these changes

@joseharriaga joseharriaga Awaiting requested review from joseharriaga joseharriaga is a code owner

@trrwilson trrwilson Awaiting requested review from trrwilson trrwilson is a code owner

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja ShivangiReja is a code owner

+1 more reviewer

@stephentoub stephentoub stephentoub approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christothes @stephentoub @KrzysztofCwalina