Skip to content

improve performance of BinaryData construction #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2025
Merged

improve performance of BinaryData construction #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/Chat/Example08_ChatSerialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public static BinaryData SerializeMessages(IEnumerable<ChatMessage> messages)
writer.WriteEndArray();
writer.Flush();

return BinaryData.FromBytes(stream.ToArray());
return BinaryData.FromBytes(stream.GetBuffer().AsMemory(0, (int)stream.Length));
}
#endregion

Expand Down
6 changes: 3 additions & 3 deletions src/Custom/Embeddings/EmbeddingClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ private void CreateEmbeddingGenerationOptions(string input, ref EmbeddingGenerat
writer.WriteStringValue(input);
writer.Flush();

options.Input = BinaryData.FromBytes(stream.ToArray());
options.Input = BinaryData.FromBytes(stream.GetBuffer().AsMemory(0, (int)stream.Length));
options.Model = _model;
options.EncodingFormat = InternalCreateEmbeddingRequestEncodingFormat.Base64;
}
Expand All @@ -237,7 +237,7 @@ private void CreateEmbeddingGenerationOptions(IEnumerable<string> inputs, ref Em
writer.WriteEndArray();
writer.Flush();

options.Input = BinaryData.FromBytes(stream.ToArray());
options.Input = BinaryData.FromBytes(stream.GetBuffer().AsMemory(0, (int)stream.Length));
options.Model = _model;
options.EncodingFormat = InternalCreateEmbeddingRequestEncodingFormat.Base64;
}
Expand All @@ -264,7 +264,7 @@ private void CreateEmbeddingGenerationOptions(IEnumerable<ReadOnlyMemory<int>> i
writer.WriteEndArray();
writer.Flush();

options.Input = BinaryData.FromBytes(stream.ToArray());
options.Input = BinaryData.FromBytes(stream.GetBuffer().AsMemory(0, (int)stream.Length));
options.Model = _model;
options.EncodingFormat = InternalCreateEmbeddingRequestEncodingFormat.Base64;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Custom/Moderations/ModerationClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ private void CreateModerationOptions(string input, ref ModerationOptions options
writer.WriteStringValue(input);
writer.Flush();

options.Input = BinaryData.FromBytes(stream.ToArray());
options.Input = BinaryData.FromBytes(stream.GetBuffer().AsMemory(0, (int)stream.Length));
options.Model = _model;
}

Expand All @@ -189,7 +189,7 @@ private void CreateModerationOptions(IEnumerable<string> inputs, ref ModerationO
writer.WriteEndArray();
writer.Flush();

options.Input = BinaryData.FromBytes(stream.ToArray());
options.Input = BinaryData.FromBytes(stream.GetBuffer().AsMemory(0, (int)stream.Length));
options.Model = _model;
}
}