Skip to content

Comments

send 2B structs instead of T structs in ChallengeReq#202

Merged
gh4683 merged 1 commit intomainfrom
fix-challenge
Jan 13, 2026
Merged

send 2B structs instead of T structs in ChallengeReq#202
gh4683 merged 1 commit intomainfrom
fix-challenge

Conversation

@gh4683
Copy link
Contributor

@gh4683 gh4683 commented Jan 12, 2026

Currently the HMAC public key, duplicate and inSymSeed are being sent in T form, instead of 2B form. We need to fix this to allow the challenge to be correctly imported into the device.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20936834649

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.958%

Totals Coverage Status
Change from base Build 20904261039: 0.0%
Covered Lines: 2005
Relevant Lines: 3786

💛 - Coveralls

@gh4683 gh4683 marked this pull request as ready for review January 12, 2026 22:20
@gh4683 gh4683 requested a review from a team as a code owner January 12, 2026 22:20
@gh4683 gh4683 requested a review from betuls January 12, 2026 22:20
@gh4683 gh4683 merged commit ec2e3f2 into main Jan 13, 2026
11 checks passed
@gh4683 gh4683 deleted the fix-challenge branch January 13, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants