schema/manifest_backwards_compatibility_test.go: drop mediatype #552
Conversation
zhouhao3
changed the title
Signed-off-by: zhouhao <[email protected]>
zhouhao3
force-pushed
the
dle-mediatype
branch
from
8e887f5 to
6c9d479
Compare
| digest: "sha256:ce939cd86094ec89abba1168d55257dfe74781f438916737d5c0905d7afb8803", | ||
| manifestlist: `{ | ||
| "schemaVersion": 2, | ||
| "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json", |
There was a problem hiding this comment.
I don't think we want these, because (as we've covered before) manifest_backwards_compatibility_test.go is about “are we compatible with caught-in-the-wild blobs blobs?” and making local adjustments like this (even to a field which we will be ignoring in the OCI framework) defeats that purpose.
There was a problem hiding this comment.
For this I am a bit confused, if you can not modify the examples of these tests, these original test data is how to get?
There was a problem hiding this comment.
…if you can not modify the examples of these tests, these original test data is how to get?
It would be nice if all of these blobs had notes on their provenance (like we have here). And for the second example you touch in this PR, we do have those notes. For the other blobs (including the first one you touch in this PR), we're left to trust the initial authors that they found these somewhere and haven't manipulated them too much. So you can add new tests here by capturing new blobs in the wild, and we can drop blobs here if we no longer want to test backwards-compat with an old blob. But we don't want to change the existing blobs by hand.
And all of this is just for manifest_backwards_compatibility_test.go. In other files you can manipulate as much as you like.
2 participants
Signed-off-by: zhouhao [email protected]