Skip to content

schema/manifest_backwards_compatibility_test.go: drop mediatype #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

schema/manifest_backwards_compatibility_test.go: drop mediatype #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions schema/manifest_backwards_compatibility_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,9 @@ func TestBackwardsCompatibilityManifestList(t *testing.T) {
fail bool
}{
{
digest: "sha256:219f4b61132fe9d09b0ec5c15517be2ca712e4744b0e0cc3be71295b35b2a467",
digest: "sha256:ce939cd86094ec89abba1168d55257dfe74781f438916737d5c0905d7afb8803",
manifestlist: `{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"manifests": [
Copy link
Contributor

@wking wking Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want these, because (as we've covered before) manifest_backwards_compatibility_test.go is about “are we compatible with caught-in-the-wild blobs blobs?” and making local adjustments like this (even to a field which we will be ignoring in the OCI framework) defeats that purpose.

Copy link
Author

@zhouhao3 zhouhao3 Feb 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this I am a bit confused, if you can not modify the examples of these tests, these original test data is how to get?

Copy link
Contributor

@wking wking Feb 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…if you can not modify the examples of these tests, these original test data is how to get?

It would be nice if all of these blobs had notes on their provenance (like we have here). And for the second example you touch in this PR, we do have those notes. For the other blobs (including the first one you touch in this PR), we're left to trust the initial authors that they found these somewhere and haven't manipulated them too much. So you can add new tests here by capturing new blobs in the wild, and we can drop blobs here if we no longer want to test backwards-compat with an old blob. But we don't want to change the existing blobs by hand.

And all of this is just for manifest_backwards_compatibility_test.go. In other files you can manipulate as much as you like.

{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
Expand Down Expand Up @@ -136,10 +135,9 @@ func TestBackwardsCompatibilityManifest(t *testing.T) {
// "Accept: application/vnd.docker.distribution.manifest.v2+json" \
// https://registry-1.docker.io/v2/library/docker/manifests/sha256:888206c77cd2811ec47e752ba291e5b7734e3ef137dfd222daadaca39a9f17bc
{
digest: "sha256:888206c77cd2811ec47e752ba291e5b7734e3ef137dfd222daadaca39a9f17bc",
digest: "sha256:162eb372f76fe2e505941075c227a3289a26b965680cdf6db6f690acbd60bea2",
manifest: `{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"config": {
"mediaType": "application/octet-stream",
"size": 3210,
Expand Down