[Runtime] Clarify what is being referenced as "process" #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix missing ")" Signed-off-by: Rob Dolin <[email protected]>
wking
reviewed
Sep 19, 2016
| 2. The container's runtime environment MUST be created according to the configuration in [`config.json`](config.md). | ||
| If the runtime is unable to create the environment specified in the [`config.json`](config.md), it MUST generate an error. | ||
| While the resources requested in the [`config.json`](config.md) MUST be created, the user-specified code (from [`process`](config.md#process-configuration) MUST NOT be run at this time. | ||
| While the resources requested in the [`config.json`](config.md) MUST be created, the user-specified code (from [`process configuration`](config.md#process-configuration)) MUST NOT be run at this time. |
Contributor
There was a problem hiding this comment.
I'm ok adding “configuration”, but:
- I think we the link to the config section discussing the
processsetting is sufficient, so we don't need to say “configuration”, and - If we add it, “configuration” should go outside the backticks (so: “from the
processconfiguration`”).
Contributor
|
And apparently GitHub doesn't cross-link issues referenced from review comments, so I'll mention #466 from a traditional comment ;). |
Merged
Contributor
|
I don't think we need to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix missing ")"
Signed-off-by: Rob Dolin [email protected]