Skip to content

Conversation

@coolljt0725
Copy link
Member

Signed-off-by: Lei Jitang [email protected]

2. The container's runtime environment MUST be created according to the configuration in [`config.json`](config.md).
If the runtime is unable to create the environment specified in the [`config.json`](config.md), it MUST generate an error.
While the resources requested in the [`config.json`](config.md) MUST be created, the user-specified code (from [`process`](config.md#process-configuration) MUST NOT be run at this time.
While the resources requested in the [`config.json`](config.md) MUST be created, the user-specified code (from [`process`](config.md#process-configuration)) MUST NOT be run at this time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also fixed in #466 and #579. It would be nice if we could land at least one of those three PRs ;).

Signed-off-by: Lei Jitang <[email protected]>
@crosbymichael
Copy link
Member

crosbymichael commented Oct 28, 2016

LGTM

Approved with PullApprove

@hqhq
Copy link
Contributor

hqhq commented Oct 29, 2016

@wking I don't think we can get a quick consensus in #466 , and I don't the major fix in #579 is needed, so I'll merge this instead, thanks.

LGTM

Approved with PullApprove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants