Skip to content

Add scheduler annotation for backward compatibility#1217

Merged
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:masterfrom
pierDipi:compat-prev-scheduler-annotations
Mar 17, 2026
Merged

Add scheduler annotation for backward compatibility#1217
openshift-merge-bot[bot] merged 1 commit intoopendatahub-io:masterfrom
pierDipi:compat-prev-scheduler-annotations

Conversation

@pierDipi
Copy link
Member

@pierDipi pierDipi commented Mar 16, 2026

This prevents the scheduler from restarting when upgrading.

Related to https://github.com/kserve/kserve/pull/5260/changes

Summary by CodeRabbit

  • Chores
    • Updated scheduler configuration to ensure proper handling of TLS certificate expiration during service restarts.

This prevents the scheduler from restarting when upgrading.

Related to https://github.com/kserve/kserve/pull/5260/changes

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4ed10adc-8450-47c3-9667-4e1d235bcd83

📥 Commits

Reviewing files that changed from the base of the PR and between d86f3ac and 832eb0d.

📒 Files selected for processing (2)
  • config/overlays/odh/kustomization.yaml
  • config/overlays/odh/patches/config-scheduler-patch.yaml

📝 Walkthrough

Walkthrough

This change adds a new Kubernetes patch file to configure KServe's LLM scheduler component with TLS certificate handling settings. The kustomization.yaml is updated to reference the new patch, and a new patch file config-scheduler-patch.yaml defines an LLMInferenceServiceConfig that enables the certificates.kserve.io/expiration-v2 annotation on the scheduler to preserve TLS certificate expiration behavior during restarts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a scheduler annotation configuration for backward compatibility.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@bartoszmajsak bartoszmajsak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bartoszmajsak, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bartoszmajsak,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/override ci/prow/e2e-graph

@pierDipi
Copy link
Member Author

/override ci/prow/e2e-predictor

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

@pierDipi: Overrode contexts on behalf of pierDipi: ci/prow/e2e-graph

Details

In response to this:

/override ci/prow/e2e-graph

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

@pierDipi: Overrode contexts on behalf of pierDipi: ci/prow/e2e-predictor

Details

In response to this:

/override ci/prow/e2e-predictor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 7dd2611 into opendatahub-io:master Mar 17, 2026
30 of 33 checks passed
@github-project-automation github-project-automation bot moved this from New/Backlog to Done in ODH Model Serving Planning Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants