-
Notifications
You must be signed in to change notification settings - Fork 44
[RHOAIENG-31730] extract the oauth proxy image into params.env file #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
===========================================
+ Coverage 56.84% 67.67% +10.82%
===========================================
Files 11 9 -2
Lines 3082 2116 -966
===========================================
- Hits 1752 1432 -320
+ Misses 1155 555 -600
+ Partials 175 129 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is to enable automate update in the product builds. We still have a reference of the oauth proxy image in the notebook_oauth.go file. It is used as a fallback if the --oauth-proxy-image argument isn't given to the manager process.
8ae9c53
to
db6b376
Compare
…af57d0 (opendatahub-io#671) Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
https://issues.redhat.com/browse/RHOAIENG-31730
This is to enable automate update in the product builds.
We still have a reference of the oauth proxy image in the
notebook_oauth.go file. It is used as a fallback if the
--oauth-proxy-image argument isn't given to the manager process.
Description
How Has This Been Tested?
Merge criteria: