Add reference to etcd and ose-cli rhel9 manifest list image#369
Conversation
WalkthroughAdded Kustomize vars Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Env as params.env
participant CM as ConfigMap(mesh-parameters)
participant K as Kustomize (odh overlay)
participant Q as Quickstart Deployment
participant F as FVT manifests
participant D as Internal Deployment Template
Env->>K: provide default `ose-etcd` and `ose-cli`
CM-->>K: fieldRef reads data.ose-etcd / data.ose-cli
K->>K: create vars `ose-etcd`, `ose-cli`
K->>Q: substitute `$(ose-cli)` -> initContainers[].image
K->>Q: substitute `$(ose-etcd)` -> containers[].image
K->>F: inject `$(ose-etcd)` into dependency fvt.yaml
note right of D: oauth-proxy images replaced in template and testdata (no runtime control-flow change)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (4)
🔇 Additional comments (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
davidebianchi
force-pushed
the
feat/RHOAIENG-32222
branch
from
8e2ce86 to
7b5a1db
Compare
davidebianchi
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
config/overlays/odh/params.yaml (1)
8-13: Good addition: initContainers image path now covered; consider future-proofing for other workload kindsThe added varReference for Deployment initContainers[]/image is correct. Optional hardening: include common kinds that might reference these images in the future (Pod, Job, CronJob, DaemonSet, StatefulSet), so placeholders won’t slip through if usage expands.
Apply this diff to extend coverage:
varReference: - path: metadata/namespace kind: ServiceAccount - path: metadata/name kind: ClusterRoleBinding - path: subjects/namespace kind: RoleBinding - path: spec/template/spec/containers[]/image kind: Deployment - path: spec/template/spec/initContainers[]/image kind: Deployment + - path: spec/containers[]/image + kind: Pod + - path: spec/initContainers[]/image + kind: Pod + - path: spec/template/spec/containers[]/image + kind: Job + - path: spec/template/spec/initContainers[]/image + kind: Job + - path: spec/jobTemplate/spec/template/spec/containers[]/image + kind: CronJob + - path: spec/jobTemplate/spec/template/spec/initContainers[]/image + kind: CronJob + - path: spec/template/spec/containers[]/image + kind: DaemonSet + - path: spec/template/spec/initContainers[]/image + kind: DaemonSet + - path: spec/template/spec/containers[]/image + kind: StatefulSet + - path: spec/template/spec/initContainers[]/image + kind: StatefulSet - path: data kind: ConfigMapconfig/dependencies/fvt.yaml (1)
46-53: Duplicate --data-dir argument passed to etcdThe command list includes --data-dir /tmp/etcd.data twice. It’s harmless (last one wins), but confusing.
Apply this diff to remove the duplicate:
- etcd - - --data-dir # use data directory under /tmp for read/write access by non-root user on OpenShift - - /tmp/etcd.data - --listen-client-urls - http://0.0.0.0:2379 - --advertise-client-urls - http://0.0.0.0:2379 - "--data-dir" - /tmp/etcd.dataopendatahub/scripts/manifests/params.env (1)
8-9: Add ose-cli to keep scripts/manifests generation in syncQuickstart now uses $(ose-cli) for the init container. If this params.env drives that overlay (or related generated manifests), also add the ose-cli entry here to avoid unresolved placeholders.
odh-model-controller=quay.io/opendatahub/odh-model-controller:fast etcd=registry.redhat.io/openshift4/ose-etcd-rhel9@sha256:ea7545b79599f3868d442fdffdfe9b12a02a4b56ac155f02c0fac4720d475796 +ose-cli=registry.redhat.io/openshift4/ose-cli-rhel9@sha256:<digest>Replace with the intended RHEL9 manifest list digest used elsewhere in the PR.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (8)
config/dependencies/fvt.yaml(1 hunks)config/overlays/odh/kustomization.yaml(1 hunks)config/overlays/odh/params.env(1 hunks)config/overlays/odh/params.yaml(1 hunks)config/overlays/odh/quickstart.yaml(3 hunks)opendatahub/scripts/README.md(1 hunks)opendatahub/scripts/manifests/fvt/fvt.yaml(1 hunks)opendatahub/scripts/manifests/params.env(1 hunks)
🔇 Additional comments (7)
opendatahub/scripts/README.md (1)
22-22: Fix looks good: corrected cheatsheet linkThe updated link path is correct and removes the stray underscore.
config/overlays/odh/params.env (1)
5-6: All etcd and ose-cli placeholders are correctly wired and substituted
- The
mesh-parametersConfigMap (viaconfigMapGenerator) includes the newetcdandose-clikeys fromparams.env.- In
config/overlays/odh/kustomization.yaml, thevarssection defines bothetcdandose-clipointing todata.etcdanddata.ose-clirespectively.- The
varReferenceentries inconfig/overlays/odh/params.yamlcover:
spec/template/spec/containers[]/imagespec/template/spec/initContainers[]/imagedataon ConfigMaps- All occurrences of
$(etcd)and$(ose-cli)in:
config/overlays/odh/quickstart.yamlconfig/dependencies/fvt.yaml
are within those supported fields/kinds and will be substituted by Kustomize.No further changes needed.
config/overlays/odh/kustomization.yaml (1)
58-71: Vars for etcd and ose-cli wired correctlyFieldRefs to mesh-parameters.data.{etcd,ose-cli} look good and match the new params.env entries.
config/dependencies/fvt.yaml (1)
56-56: Parametrizing etcd image looks good; confirm substitution occurs in this contextUsing $(etcd) aligns with the new pattern. Please verify that the kustomize config that consumes this file defines the etcd var and includes a varReference for spec/template/spec/containers[]/image for kind=Deployment; otherwise this placeholder won’t resolve at build time.
config/overlays/odh/quickstart.yaml (3)
52-52: Init image parametrization is consistentSwitching to $(ose-cli) is aligned with the new variable-based approach. Ensure params.yaml (kustomize-config) includes varReference for spec/template/spec/initContainers[]/image so this resolves during build (your PR notes suggest you did this).
75-75: Whitespace-only tweakNo functional impact. OK to keep.
95-95: Main etcd image now parameterizedLooks good. Please confirm kustomize varReference still covers spec/template/spec/containers[]/image (for Deployment) in addition to initContainers[]/image; otherwise $(etcd) here may not be substituted after your recent params.yaml edit.
| # image: quay.io/coreos/etcd:v3.5.4 | ||
| # Tag -> registry.access.redhat.com/rhel7/etcd:3.2.32-34 | ||
| image: registry.redhat.io/openshift4/ose-etcd@sha256:d3275cd886d13865937d225d8138db7f6b7bf59ac1a94d9fbe61e35286bee6ff | ||
| image: $(etcd) |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Switch to $(etcd) placeholder is fine; verify substitution is wired in scripts/manifests
Since this path isn’t under config/overlays/odh/, ensure the scripts/manifests kustomization (or templating step) will substitute $(etcd) using its own params.env/ConfigMap. Otherwise this will deploy with an unresolved literal string.
Apply this script to confirm substitution wiring:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Searching for a kustomization under opendatahub/scripts/manifests..."
fd -HI --glob kustomization.yaml opendatahub/scripts/manifests | sed 's/^/ - /' || true
echo
echo "Show any params.env in scripts/manifests:"
fd -HI --glob params.env opendatahub/scripts/manifests | sed 's/^/ - /' | while read -r f; do
echo "---- $f"; sed -n '1,120p' "$f"; echo; done
echo
echo "Look for varReferences that would cover images in Deployments/Pods:"
fd -HI --glob params.yaml opendatahub/scripts/manifests | while read -r f; do
echo "---- $f"; sed -n '1,200p' "$f"; echo; done
echo
echo "Confirm all placeholders in scripts/manifests:"
rg -nC2 -e '\$\((etcd|ose-cli)\)' opendatahub/scripts/manifests || trueLength of output: 2607
I’ll pull in the relevant kustomize config and params to confirm that $(etcd) is defined and wired correctly:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Kustomization files under scripts/manifests:"
fd -HI --glob kustomization.yaml opendatahub/scripts/manifests | sed 's/^/ - /'
echo
echo "Contents of fvt kustomization.yaml:"
sed -n '1,200p' opendatahub/scripts/manifests/fvt/kustomization.yaml
echo
echo "Contents of params.env:"
sed -n '1,200p' opendatahub/scripts/manifests/params.env
echo
echo "Vars & ConfigMapGenerator in fvt kustomization.yaml:"
rg -n -C3 '^(vars:|configMapGenerator)' opendatahub/scripts/manifests/fvt/kustomization.yaml || true
echo
echo "Placeholder occurrences for $(etcd):"
rg -nC2 '\$\((etcd)\)' opendatahub/scripts/manifests/fvt || trueLength of output: 2244
Wire the $(etcd) placeholder in fvt/kustomization.yaml
The current kustomization under scripts/manifests/fvt doesn’t load params.env nor declare a var for etcd, so image: $(etcd) will remain literal at deploy time.
Please update opendatahub/scripts/manifests/fvt/kustomization.yaml to include:
- A ConfigMapGenerator that pulls in
params.env - A vars entry that points
etcdat the generated ConfigMap’sdata.etcdfield
For example:
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- fvt.yaml
patchesStrategicMerge:
- remove_etcd_patch.yaml
namespace: modelmesh-serving
+# load all key=values from params.env, including etcd
+configMapGenerator:
+ - name: etcd-params
+ env: ../params.env
+
+vars:
+ - name: etcd
+ objref:
+ kind: ConfigMap
+ name: etcd-params
+ apiVersion: v1
+ fieldref:
+ fieldpath: data.etcdEnsure the relative path to params.env is correct and that kustomize version supports vars substitution. After this change, image: $(etcd) will be replaced with the SHA-pinned RHEL9 etcd image.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| image: $(etcd) | |
| apiVersion: kustomize.config.k8s.io/v1beta1 | |
| kind: Kustomization | |
| resources: | |
| - fvt.yaml | |
| patchesStrategicMerge: | |
| - remove_etcd_patch.yaml | |
| namespace: modelmesh-serving | |
| # load all key=values from params.env, including etcd | |
| configMapGenerator: | |
| - name: etcd-params | |
| env: ../params.env | |
| vars: | |
| - name: etcd | |
| objref: | |
| kind: ConfigMap | |
| name: etcd-params | |
| apiVersion: v1 | |
| fieldref: | |
| fieldpath: data.etcd |
🤖 Prompt for AI Agents
In opendatahub/scripts/manifests/fvt/kustomization.yaml (near where
resources/patches are declared), add a ConfigMapGenerator that loads the
params.env file and a vars entry mapping the name "etcd" to the generated
ConfigMap's data.etcd field so the $(etcd) placeholder is substituted.
Specifically: add a configMapGenerator block that references the relative path
to params.env (ensure the path is correct from this kustomization file) and
gives the ConfigMap a stable name, then add a vars section with name: etcd,
objref pointing to that ConfigMap (kind: ConfigMap, name: <generated-name>) and
fieldref: data.etcd. Confirm your kustomize version supports vars substitution.
…tahub Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
davidebianchi
force-pushed
the
feat/RHOAIENG-32222
branch
from
d9d823b to
dcc4881
Compare
grdryn
left a comment
grdryn
left a comment
There was a problem hiding this comment.
Looks like the right approach, thanks @davidebianchi! I'm not all that familiar with this project, so will try to get someone more knowledgeable to take a look. 🙂
I've left a couple of comments/thoughts inline below also.
| # image: quay.io/coreos/etcd:v3.5.4 | ||
| # Tag -> registry.access.redhat.com/rhel7/etcd:3.2.32-34 | ||
| image: registry.redhat.io/openshift4/ose-etcd@sha256:d3275cd886d13865937d225d8138db7f6b7bf59ac1a94d9fbe61e35286bee6ff | ||
| image: registry.redhat.io/openshift4/ose-etcd-rhel9@sha256:ea7545b79599f3868d442fdffdfe9b12a02a4b56ac155f02c0fac4720d475796 |
There was a problem hiding this comment.
I'm interested to know how this one is used, and why it can't be changed to $(etcd). I guess it's because it's not kustomized in the same way? I wonder if maybe it should be?
There was a problem hiding this comment.
Yes, it is not kustomized in the same way. I could have added into the kustomization file the same override, but I noticed that there is a patch to delete the etcd configurations.
So, I thought it's no longer useful. I’d like to understand whether it makes sense to handle this here as well, or if it’s not really needed.
There was a problem hiding this comment.
this is only for test purposes, fvp on ci.
There was a problem hiding this comment.
Ok, thank you. What do you think could be the best way to manage it? Use the params.env as in config overlays, or keep as is?
There was a problem hiding this comment.
Sounds like it should be fine to keep it as you have it here, if it's just for testing purposes.
There was a problem hiding this comment.
I noticed that fvt github actions does not run, there is an error and are never triggered. Is it known? Was it intentional?
|
@brettmthompson can you please take a look? |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
config/overlays/odh/params.env (3)
5-6: Add a brief comment to document intent (operator will pin digests)A short note helps future maintainers understand why tags (not digests) are used here.
Apply this diff:
-ose-etcd=registry.redhat.io/openshift4/ose-etcd-rhel9:v4.19 -ose-cli=registry.redhat.io/openshift4/ose-cli-rhel9:v4.19 +# Defaults use minor-stream tags; operator/overrides are expected to pin to digests. +ose-etcd=registry.redhat.io/openshift4/ose-etcd-rhel9:v4.19 +ose-cli=registry.redhat.io/openshift4/ose-cli-rhel9:v4.19
5-6: Confirm pull access and mirroring strategy for registry.redhat.ioThese images require valid pull credentials. Please verify:
- Target clusters have the necessary pull-secret access to registry.redhat.io for workloads in this namespace.
- For disconnected/air-gapped environments, operator overrides (or a mirror/ICSP) are in place to point to mirrored ose-etcd/ose-cli images.
Optionally note in the README/overlay docs that these params are defaults and may be overridden by operator-supplied, digest-pinned, mirrored images for disconnected clusters.
5-6: Confirm kustomize varReference coverage and hyphenated var supportI inspected config/overlays/odh/kustomization.yaml and found:
- No varReference block is defined (only a single vars: entry for mesh-namespace at lines 22–27).
- The only vars declared are for mesh-namespace; ose-etcd and ose-cli aren’t listed under vars:.
- There is a ConfigMap with keys data.ose-etcd and data.ose-cli (lines 56–70), but without corresponding vars and varReference entries, kustomize won’t substitute
$(ose-etcd)or$(ose-cli)in Deployment images.Please verify:
- Your kustomize version’s default varReference covers both
spec/template/spec/containers[]/imagespec/template/spec/initContainers[]/image
under kind: Deployment, so you don’t need to explicitly declare them.- Hyphenated var names (
ose-etcd,ose-cli) are supported by your kustomize version (some versions only allow[A-Za-z0-9_]+).If either condition is not met, you should:
- Add vars for ose-etcd and ose-cli and broaden varReference:
vars: - name: ose-etcd objref: kind: ConfigMap name: mesh-parameters apiVersion: v1 fieldref: fieldpath: data.ose-etcd - name: ose-cli objref: kind: ConfigMap name: mesh-parameters apiVersion: v1 fieldref: fieldpath: data.ose-cli varReference: - kind: Deployment path: spec/template/spec/containers[]/image - kind: Deployment path: spec/template/spec/initContainers[]/image- Or rename vars to use underscores (e.g.
ose_etcd,ose_cli) if hyphens aren’t supported.To double-check no placeholders remain after build, run locally (expect no matches):
kustomize build config/overlays/odh \ | rg -nP '\$\((ose-etcd|ose-cli)\)' || true
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
config/dependencies/fvt.yaml(1 hunks)config/overlays/odh/kustomization.yaml(1 hunks)config/overlays/odh/params.env(1 hunks)config/overlays/odh/quickstart.yaml(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- config/dependencies/fvt.yaml
- config/overlays/odh/quickstart.yaml
- config/overlays/odh/kustomization.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
config/overlays/odh/params.env (1)
5-6: Tag-based defaults (v4.19) for ose-etcd/ose-cli — LGTMSwitching from digests to tags here matches the earlier review guidance and keeps the defaults aligned with the OCP 4.19 minor stream. It also cleanly supports operator-side digest pinning via overrides.
Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
davidebianchi
force-pushed
the
feat/RHOAIENG-32222
branch
from
af270c0 to
9be99ad
Compare
| odh-modelmesh=quay.io/opendatahub/modelmesh:fast | ||
| odh-modelmesh-controller=quay.io/opendatahub/modelmesh-controller:fast | ||
| ose-etcd=registry.redhat.io/openshift4/ose-etcd-rhel9:v4.19 | ||
| ose-cli=registry.redhat.io/openshift4/ose-cli-rhel9:v4.19 |
There was a problem hiding this comment.
Any particular reason for adding it? (the cli one)
There was a problem hiding this comment.
To follow the dependency management guidelines. It was in the same manifest, so I updated them together. Do you see any problems?
There was a problem hiding this comment.
@spolti the idea here is that of RHOAIENG-25619, where the images can be kept consistent with the rest of RHOAI, rather than the old approach of every component specifying their own version of everything, and those all going stale and having 7 different versions of the same image across the different components.
There was a problem hiding this comment.
Actually, there are oauth-proxy references in this repository also: https://github.com/search?q=repo%3Aopendatahub-io%2Fmodelmesh-serving+oauth-proxy&type=code
Should/could those also be updated here?
There was a problem hiding this comment.
@grdryn I am confused now, will ose-cli replace ose ose-proxy? If not, why add ose-cli?
There was a problem hiding this comment.
@spolti ose-cli is a different case than oauth-proxy. The idea is to keep all 3rd party images (or at least other images from RH registry) up-to-date, so ose-cli is being added because it's referenced in config/overlays/odh/quickstart.yaml on L52 (and you can see the reference is updated in this PR).
So maybe we should have a 3rd entry here for ose-oauth-proxy? Or I guess that would actually need to be passed to that deployment.yaml.tmpl from here 🤔 Maybe we should update the static reference once in this PR, and then consider parameterizing that and figuring out how to feed the image through in a potential follow-up change?
There was a problem hiding this comment.
I see, thanks.
Yes, this template is processed at runtime, we could add the image there and later patch it accordingly.
There was a problem hiding this comment.
Shall we already add the proxy as part of this PR?
There was a problem hiding this comment.
I'm easy with it either being done in this PR or another one. Which would you prefer? Maybe we could get this one merged, then create a follow up one for that (or potentially 2 follow ups: one to just update the static image reference in place, then a second to have the image passed through, if that's even a reasonable thing to do)?
There was a problem hiding this comment.
I updated the oauth-proxy static reference here. Passing the image through is something I'd do in a separate PR.
Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
davidebianchi
force-pushed
the
feat/RHOAIENG-32222
branch
from
167d83c to
8f75a2d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidebianchi, spolti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@spolti is main the correct branch for this to get synced down to rhds? Looks like maybe it needs to be on a branch called Also I wonder if it'll need to be on a |
|
/cherrypick release-0.12.0-rc0 ^Not sure if I have the power to do that in this repo. Doing it optimistically in the hopes that it saves some time in case it needs to be done. |
|
@grdryn: #369 failed to apply on top of branch "release-0.12.0-rc0": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@grdryn, sry for the delay, the branch which we sync with rhoai is At this point, any change that needs to land on 2.25 should be cherry-picked to both branches, including main. |
|
Do you guys need help cherry-picking it to the release branches? |
…hub-io#369) * feat(RHOAIENG-32222): add reference to etcd rhel9 manifest list image Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> * feat(RHOAIENG-32222): add reference to ose-cli rhel9 manifest list image Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> * feat(RHOAIENG-32222): rename etcd image Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> * fix(RHOAIENG-32222): substitute vars in initContainers Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> * feat(RHOAIENG-32222): set specific image to etcd deployment in opendatahub Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> * feat: rename etcd to ose-etcd Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> * feat: update static reference to oauth-proxy Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> --------- Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
) * feat(RHOAIENG-32222): add reference to etcd rhel9 manifest list image * feat(RHOAIENG-32222): add reference to ose-cli rhel9 manifest list image * feat(RHOAIENG-32222): rename etcd image * fix(RHOAIENG-32222): substitute vars in initContainers * feat(RHOAIENG-32222): set specific image to etcd deployment in opendatahub * feat: rename etcd to ose-etcd * feat: update static reference to oauth-proxy --------- Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> Co-authored-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
) * feat(RHOAIENG-32222): add reference to etcd rhel9 manifest list image * feat(RHOAIENG-32222): add reference to ose-cli rhel9 manifest list image * feat(RHOAIENG-32222): rename etcd image * fix(RHOAIENG-32222): substitute vars in initContainers * feat(RHOAIENG-32222): set specific image to etcd deployment in opendatahub * feat: rename etcd to ose-etcd * feat: update static reference to oauth-proxy --------- Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> Co-authored-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com>
…hub-io#369) (opendatahub-io#373) * feat(RHOAIENG-32222): add reference to etcd rhel9 manifest list image * feat(RHOAIENG-32222): add reference to ose-cli rhel9 manifest list image * feat(RHOAIENG-32222): rename etcd image * fix(RHOAIENG-32222): substitute vars in initContainers * feat(RHOAIENG-32222): set specific image to etcd deployment in opendatahub * feat: rename etcd to ose-etcd * feat: update static reference to oauth-proxy --------- Signed-off-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> Co-authored-by: Davide Bianchi <10374360+davidebianchi@users.noreply.github.com> Signed-off-by: Mariah Holder <marholde@redhat.com>
4 participants
Motivation
Update etcd and ose-cli images to follow guidelines
Modifications
Updated ectd and ose-cli images.
Result
Test the release with opendatahub-operator, and it release the correct images.
PR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags
Checklist items below are applicable for development targeted to both fast and stable branches/tags
Summary by CodeRabbit
New Features
Chores
Documentation