Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/dependencies/fvt.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ spec:
- /tmp/etcd.data
# image: quay.io/coreos/etcd:v3.5.4
# Tag -> registry.access.redhat.com/rhel7/etcd:3.2.32-34
image: registry.redhat.io/openshift4/ose-etcd@sha256:d3275cd886d13865937d225d8138db7f6b7bf59ac1a94d9fbe61e35286bee6ff
image: $(etcd)
name: etcd
ports:
- containerPort: 2379
Expand Down
14 changes: 14 additions & 0 deletions config/overlays/odh/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,20 @@ vars:
apiVersion: v1
kind: ConfigMap
name: mesh-parameters
- fieldref:
fieldPath: data.etcd
name: etcd
objref:
apiVersion: v1
kind: ConfigMap
name: mesh-parameters
- fieldref:
fieldPath: data.ose-cli
name: ose-cli
objref:
apiVersion: v1
kind: ConfigMap
name: mesh-parameters



Expand Down
2 changes: 2 additions & 0 deletions config/overlays/odh/params.env
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@ odh-mm-rest-proxy=quay.io/opendatahub/rest-proxy:fast
odh-modelmesh-runtime-adapter=quay.io/opendatahub/modelmesh-runtime-adapter:fast
odh-modelmesh=quay.io/opendatahub/modelmesh:fast
odh-modelmesh-controller=quay.io/opendatahub/modelmesh-controller:fast
etcd=registry.redhat.io/openshift4/ose-etcd-rhel9@sha256:ea7545b79599f3868d442fdffdfe9b12a02a4b56ac155f02c0fac4720d475796
ose-cli=registry.redhat.io/openshift4/ose-cli-rhel9@sha256:a11ea4a722fadc2cdf532675dd409d384342bea15559aec4b10c2b12ab6d3041
2 changes: 2 additions & 0 deletions config/overlays/odh/params.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ varReference:
kind: RoleBinding
- path: spec/template/spec/containers[]/image
kind: Deployment
- path: spec/template/spec/initContainers[]/image
kind: Deployment
- path: data
kind: ConfigMap
8 changes: 4 additions & 4 deletions config/overlays/odh/quickstart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ spec:
defaultMode: 0554
initContainers:
- name: etcd-secret-creator
image: registry.redhat.io/openshift4/ose-cli@sha256:4cfb4219f46c8cc25a5e567fd4cb8babe9a3778b0b86a1e354a3403994ef3677
image: $(ose-cli)
command: ["/bin/bash", "-c", "--"]
args:
- |
Expand All @@ -69,10 +69,10 @@ spec:
exit 0
elif [[ $etcdpasswordexists == "false" && $modelservingetcdexists != "false" ]]; then
echo "model-serving-etcd exists, creating etcdpasswords secret"
ETC_ROOT_PSW=$(oc get secrets/model-serving-etcd --template={{.data.etcd_connection}} | base64 -d | grep -o '"password": *"[^"]*"' | grep -o '"[^"]*"$' | grep -oP '"\K[^"\047]+(?=["\047])')
ETC_ROOT_PSW=$(oc get secrets/model-serving-etcd --template={{.data.etcd_connection}} | base64 -d | grep -o '"password": *"[^"]*"' | grep -o '"[^"]*"$' | grep -oP '"\K[^"\047]+(?=["\047])')
oc create secret generic etcd-passwords --type=string --from-literal=root=$ETC_ROOT_PSW
exit 0
else
else
echo "secrets etcdpasswords and model-serving-etcd exist, doing nothing"
exit 0
fi
Expand All @@ -92,7 +92,7 @@ spec:
- http://0.0.0.0:2379
- "--data-dir"
- /tmp/etcd.data
image: registry.redhat.io/openshift4/ose-etcd@sha256:d3275cd886d13865937d225d8138db7f6b7bf59ac1a94d9fbe61e35286bee6ff
image: $(etcd)
name: etcd
env:
- name: ROOT_PASSWORD
Expand Down
2 changes: 1 addition & 1 deletion opendatahub/scripts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ manifests are the part that deploys the components required for fvt (functional

## Scripts

The scripts in this folder help you run fvt tests or compare odh manifests. However, it is not recommended to use these scripts directly without familiarizing yourself with them. [This doc has make examples](../docs/makefile_-cheatsheet.md) of using these scripts in a makefile here.
The scripts in this folder help you run fvt tests or compare odh manifests. However, it is not recommended to use these scripts directly without familiarizing yourself with them. [This doc has make examples](../docs/makefile-cheatsheet.md) of using these scripts in a makefile here.

- [env.sh](./env.sh)

Expand Down
2 changes: 1 addition & 1 deletion opendatahub/scripts/manifests/fvt/fvt.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ spec:
- /tmp/etcd.data
# image: quay.io/coreos/etcd:v3.5.4
# Tag -> registry.access.redhat.com/rhel7/etcd:3.2.32-34
image: registry.redhat.io/openshift4/ose-etcd@sha256:d3275cd886d13865937d225d8138db7f6b7bf59ac1a94d9fbe61e35286bee6ff
image: registry.redhat.io/openshift4/ose-etcd-rhel9@sha256:ea7545b79599f3868d442fdffdfe9b12a02a4b56ac155f02c0fac4720d475796
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interested to know how this one is used, and why it can't be changed to $(etcd). I guess it's because it's not kustomized in the same way? I wonder if maybe it should be?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not kustomized in the same way. I could have added into the kustomization file the same override, but I noticed that there is a patch to delete the etcd configurations.

patchesStrategicMerge:
- remove_etcd_patch.yaml

So, I thought it's no longer useful. I’d like to understand whether it makes sense to handle this here as well, or if it’s not really needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only for test purposes, fvp on ci.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thank you. What do you think could be the best way to manage it? Use the params.env as in config overlays, or keep as is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like it should be fine to keep it as you have it here, if it's just for testing purposes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that fvt github actions does not run, there is an error and are never triggered. Is it known? Was it intentional?

name: etcd
ports:
- containerPort: 2379
Expand Down