-
Notifications
You must be signed in to change notification settings - Fork 42
Add reference to etcd and ose-cli rhel9 manifest list image #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
711d0fe
b084e39
eba5fff
7b5a1db
dcc4881
9be99ad
8f75a2d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -53,7 +53,7 @@ spec: | |||||
| - /tmp/etcd.data | ||||||
| # image: quay.io/coreos/etcd:v3.5.4 | ||||||
| # Tag -> registry.access.redhat.com/rhel7/etcd:3.2.32-34 | ||||||
| image: registry.redhat.io/openshift4/ose-etcd@sha256:d3275cd886d13865937d225d8138db7f6b7bf59ac1a94d9fbe61e35286bee6ff | ||||||
| image: registry.redhat.io/openshift4/ose-etcd-rhel9@sha256:ea7545b79599f3868d442fdffdfe9b12a02a4b56ac155f02c0fac4720d475796 | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm interested to know how this one is used, and why it can't be changed to
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it is not kustomized in the same way. I could have added into the kustomization file the same override, but I noticed that there is a patch to delete the etcd configurations.
So, I thought it's no longer useful. I’d like to understand whether it makes sense to handle this here as well, or if it’s not really needed.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is only for test purposes, fvp on ci.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, thank you. What do you think could be the best way to manage it? Use the params.env as in config overlays, or keep as is?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds like it should be fine to keep it as you have it here, if it's just for testing purposes.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I noticed that fvt github actions does not run, there is an error and are never triggered. Is it known? Was it intentional? |
||||||
| name: etcd | ||||||
| ports: | ||||||
| - containerPort: 2379 | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.