Skip to content

feat: attempting a new fix for the local log format problem #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deborahgu merged 1 commit into from
Dec 6, 2024
Merged

feat: attempting a new fix for the local log format problem #2658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion credentials/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@
ACE_CHANNEL_SAILTHRU_TEMPLATE_NAME = "" # unused, but required to be set or we see an exception

# Set up logging for development use (logging to stdout)
LOGGING_FORMAT_STRING = ""
LOGGING_FORMAT_STRING = os.environ.get("LOGGING_FORMAT_STRING", "")
LOGGING = get_logger_config(debug=DEBUG, dev_env=True, local_loglevel="DEBUG", format_string=LOGGING_FORMAT_STRING)

# DRF Settings
Expand Down
2 changes: 1 addition & 1 deletion credentials/settings/devstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

ALLOWED_HOSTS = ["*"]

LOGGING_FORMAT_STRING = ""
LOGGING_FORMAT_STRING = os.environ.get("LOGGING_FORMAT_STRING", "")
LOGGING = get_logger_config(debug=True, dev_env=True, local_loglevel="DEBUG", format_string=LOGGING_FORMAT_STRING)
del LOGGING["handlers"]["local"]

Expand Down
2 changes: 1 addition & 1 deletion credentials/settings/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
USER_CACHE_TTL = 60

# LOGGING
LOGGING_FORMAT_STRING = ""
LOGGING_FORMAT_STRING = os.environ.get("LOGGING_FORMAT_STRING", "")

Check warning on line 59 in credentials/settings/local.py

View check run for this annotation

Codecov / codecov/patch

credentials/settings/local.py#L59 

Added line #L59 was not covered by tests
LOGGING = get_logger_config(debug=True, dev_env=True, local_loglevel="DEBUG", format_string=LOGGING_FORMAT_STRING)

#####################################################################
Expand Down
2 changes: 1 addition & 1 deletion credentials/settings/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"credentials.apps.edx_credentials_extensions",
]

LOGGING_FORMAT_STRING = ""
LOGGING_FORMAT_STRING = os.environ.get("LOGGING_FORMAT_STRING", "")
LOGGING = get_logger_config(debug=False, dev_env=True, local_loglevel="DEBUG", format_string=LOGGING_FORMAT_STRING)
ALLOWED_HOSTS = ["*"]

Expand Down
Loading