feat: attempting a new fix for the local log format problem#2658
Merged
feat: attempting a new fix for the local log format problem#2658
Conversation
The previous attempt to set a local log format failed because first the base configuration files are applied, in which the logging format is set via a function call, and then the overrides come in from edx-internal. Basically, there's a timing problem. This is an attempt to solve that problem in the hopes that the environment variables are set before the configuration files for the application are run. This change will be made in conjunction with a PR on at ex-internal. FIXES: APER-3805
justinhynes
approved these changes
Dec 6, 2024
deborahgu
deleted the
dkaplan1/APER-3805_take-3-fix-datadog-log-parsing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous attempt to set a local log format failed because first the base configuration files are applied, in which the logging format is set via a function call, and then our own internal overrides are applied. Basically, there's a timing problem.
This is an attempt to solve that problem in the hopes that the environment variables are set before the configuration files for the application are run. This change will be made in conjunction with an internal config PR.
FIXES: APER-3805