Skip to content

Allow tests for Extracted & Builtin HTML XBlock #36399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kdmccormick merged 1 commit into from
Aug 15, 2025
Merged

Allow tests for Extracted & Builtin HTML XBlock #36399

kdmccormick merged 1 commit into from
Aug 15, 2025

Conversation

@irtazaakram
Copy link
Member

@irtazaakram irtazaakram commented Mar 18, 2025 •
edited
Loading

Test HTML XBlock in both built-in and extracted modes to keep them in sync.

Related to: #36283

@irtazaakram irtazaakram mentioned this pull request Mar 18, 2025
Merged
8 tasks
@irtazaakram irtazaakram mentioned this pull request Apr 3, 2025
Closed
@irtazaakram irtazaakram mentioned this pull request Jul 22, 2025
Draft
8 tasks
@irtazaakram irtazaakram force-pushed the html-extracted branch 2 times, most recently from 85c2133 to e051d06 Compare July 23, 2025 07:36
kdmccormick
kdmccormick reviewed Jul 23, 2025
View reviewed changes
@irtazaakram irtazaakram added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Jul 31, 2025
@open-craft-grove
Copy link

open-craft-grove commented Jul 31, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Jul 31, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Aug 6, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@irtazaakram irtazaakram removed the create-sandbox open-craft-grove should create a sandbox environment from this PR label Aug 6, 2025
@open-craft-grove
Copy link

open-craft-grove commented Aug 6, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Aug 6, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Aug 6, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Aug 6, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@irtazaakram irtazaakram force-pushed the html-extracted branch 2 times, most recently from 39bde40 to e56ac68 Compare August 7, 2025 07:41
@irtazaakram irtazaakram added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Aug 7, 2025
@open-craft-grove
Copy link

open-craft-grove commented Aug 7, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Aug 7, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Aug 7, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan
Copy link
Contributor

farhan commented Aug 8, 2025

The changes look good to me.
I’ll approve the PR once the extracted block is released in xblocks-contrib and the requirements are updated accordingly.

farhan
farhan reviewed Aug 8, 2025
View reviewed changes
openedx/envs/common.py Outdated
# .. toggle_creation_date: 2024-11-10
# .. toggle_target_removal_date: 2025-06-01
USE_EXTRACTED_HTML_BLOCK = False
USE_EXTRACTED_HTML_BLOCK = True
Copy link
Contributor

@farhan farhan Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this flag for now as we will enable the extracted xblock to production:

  1. Once the pointer tag issue implementation is done
  2. And will roll out gradually (one by one)

@open-craft-grove
Copy link

open-craft-grove commented Aug 11, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Aug 11, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@irtazaakram irtazaakram marked this pull request as ready for review August 11, 2025 12:40
farhan
farhan previously requested changes Aug 11, 2025
View reviewed changes
@open-craft-grove
Copy link

open-craft-grove commented Aug 13, 2025

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

open-craft-grove commented Aug 13, 2025

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

kdmccormick
kdmccormick reviewed Aug 14, 2025
View reviewed changes
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the title and description to match what the PR is doing.

@kdmccormick kdmccormick removed the create-sandbox open-craft-grove should create a sandbox environment from this PR label Aug 14, 2025
@irtazaakram irtazaakram changed the title Test PR | Enable Extracted HTML XBlock Allow tests for Extracted & Builtin HTML XBlock Aug 15, 2025
@kdmccormick kdmccormick requested review from farhan and removed request for farhan August 15, 2025 15:41
@kdmccormick kdmccormick dismissed farhan’s stale review August 15, 2025 15:42

changes addressed

@kdmccormick kdmccormick merged commit bbfdce0 into master Aug 15, 2025
49 checks passed
@kdmccormick kdmccormick deleted the html-extracted branch August 15, 2025 15:42
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Aug 15, 2025

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Aug 15, 2025

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Aug 15, 2025

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Aug 15, 2025

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Aug 15, 2025

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

edx-pipeline-bot commented Aug 15, 2025

2U Release Notice: This PR has been deployed to the edX production environment.

rpenido pushed a commit to open-craft/edx-platform that referenced this pull request Aug 16, 2025
@irtazaakram @rpenido
fix: Allow tests for Extracted & Builtin HTML XBlock (openedx#36399)
510bda7 
Test HTML XBlock in both built-in and extracted modes to keep them in sync.

Related to: openedx#36283
salman2013 pushed a commit to salman2013/edx-platform that referenced this pull request Sep 10, 2025
@irtazaakram @salman2013
fix: Allow tests for Extracted & Builtin HTML XBlock (openedx#36399)
bf58d5e 
Test HTML XBlock in both built-in and extracted modes to keep them in sync.

Related to: openedx#36283
@salman2013 salman2013 mentioned this pull request Sep 23, 2025
Merged
@ormsbee ormsbee mentioned this pull request Nov 7, 2025
Merged
@salman2013 salman2013 mentioned this pull request Dec 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kdmccormick kdmccormick kdmccormick approved these changes

@salman2013 salman2013 salman2013 approved these changes

@farhan farhan farhan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@irtazaakram @open-craft-grove @farhan @edx-pipeline-bot @kdmccormick @salman2013