-
Notifications
You must be signed in to change notification settings - Fork 3
Adds HTML XBlock extracting from edx-platform repo #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhan
requested changes
Mar 22, 2025
farhan
reviewed
Mar 22, 2025
kdmccormick
reviewed
May 21, 2025
kdmccormick
requested changes
Jul 14, 2025
salman2013
approved these changes
Aug 8, 2025
Contributor
salman2013
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have tested this PR on the sandbox with test enabled PR, everything seems working as expected, just one iFrame image is not loading on chrome but just on sandbox, locally extracted code is working properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds HTML xblock extracting from edx-platform repo
Description
raw editor is deprecated and is replaced by https://github.com/openedx/frontend-app-authoring
Test PR
Make a test PR on
edx-platformlike this to run test cases on under development PR.File references:
xblocks_contrib/html/html.pyhas been extracted fromxblocks_contrib/html/utils.pyhas been extracted fromxblocks_contrib/html/static/css/html.csshas been extracted fromxblocks_contrib/html/tests/test_html.pyhas been extracted from here and hereAcceptance Criteria:
Relevant Issue: openedx/edx-platform#36283