-
Notifications
You must be signed in to change notification settings - Fork 4
[backport] adding namespace to permissions #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backport] adding namespace to permissions #38
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
97d996f to
d4a233f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/ulmo #38 +/- ##
=============================================
Coverage 94.32% 94.33%
=============================================
Files 44 44
Lines 881 882 +1
Branches 176 174 -2
=============================================
+ Hits 831 832 +1
Misses 48 48
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ec88c12 to
8318606
Compare
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
|
Thank you @arbrandes |
Description
BACKPORT for release/ulmo branch for:
Updating namespaces to permissions to use name spaced identifiers by adding the
content_librariesprefix.Example:
Before:
delete_libraryAfter
content_libraries.delete_libraryThe permissions used/mocked on the unit tests were also modified to keep consistency.
Closes #35
Related to: openedx/openedx-authz#136
Also had to add ts-jest as devDependency to fix broken test workflow:
Important
Dependency
openedx/openedx-authz#142
How to test it
Make sure you are running openedx-authz v0.16.0
npm install&&npm run devScreenshots of the
RolesandPermissiontabs