[DO NOT MERGE] feat!: remove custom header settings #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnwesson
force-pushed
the
jwesson/remove-custom-header-configuration
branch
from
c4da289 to
de1a9d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #633 +/- ##
==========================================
- Coverage 97.52% 97.47% -0.05%
==========================================
Files 152 149 -3
Lines 1332 1307 -25
Branches 229 221 -8
==========================================
- Hits 1299 1274 -25
Misses 32 32
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsnwesson
force-pushed
the
jwesson/remove-custom-header-configuration
branch
from
de1a9d0 to
3663efb
Compare
jsnwesson
changed the title
|
Todo: I think there are some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to remove the custom header settings for Learner Dashboard. Most of these features already exist as the default experience in
frontend-component-header, minus the Programs/Discover New tabs, the Support link, and other 2U-specific features.