Skip to content

build: Upgrade to Node 24 #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PKulkoRaccoonGang
Copy link

@PKulkoRaccoonGang PKulkoRaccoonGang commented Aug 12, 2025

Note

Awaiting a merge:

Description

As a second step in the Node 24 upgrade process, upgrade .nvmrc and regenerate package-lock.json from scratch using Node 24. Also make the Node 24 test a blocking one.

See the tracking issue for futher information.

@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @2U-aperture.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Aug 12, 2025
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 12, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 12, 2025
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/node24-upgrade-2 branch from 043a989 to e58b9c7 Compare August 12, 2025 06:30
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.60%. Comparing base (9e4faf1) to head (403add5).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #702   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files         152      152           
  Lines        1337     1337           
  Branches      232      232           
=======================================
  Hits         1305     1305           
  Misses         31       31           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -0,0 +1,11 @@
{
Copy link
Author

@PKulkoRaccoonGang PKulkoRaccoonGang Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[inform]: The addition of tsconfig.json is caused by an error when importing the TS file from the header.

Module './StudioHeader' was resolved to '/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learner-dashboard/node_modules/@edx/frontend-component-header/dist/studio-header/StudioHeader.tsx', but '--jsx' is not set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: No status
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants