Skip to content

build: Upgrade to Node 24 #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

build: Upgrade to Node 24 #702

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18b6e1d
test: Add Node 24 to CI matrix
PKulkoRaccoonGang Aug 12, 2025
403add5
build: Upgrade to Node 24
PKulkoRaccoonGang Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
strategy:
matrix:
node: [20, 24]
continue-on-error: ${{ matrix.node == 24 }}

steps:
- name: Checkout
Expand All @@ -23,7 +22,7 @@ jobs:
- name: Setup Nodejs
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
node-version-file: '.nvmrc'

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20
24
2,121 changes: 620 additions & 1,501 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@
"devDependencies": {
"@edx/browserslist-config": "^1.3.0",
"@edx/reactifex": "^2.1.1",
"@edx/typescript-config": "^1.1.0",
"@openedx/frontend-build": "^14.3.3",
"@testing-library/jest-dom": "^6.6.3",
"@testing-library/react": "^16.2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/containers/RelatedProgramsModal/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const messages = defineMessages({
description: {
id: 'learner-dash.relatedPrograms.description',
description: 'Description for related settings modal',
defaultMessage: `Are you looking to expand your knowledge? Enrolling in a Program lets you take a series of courses in the subject that you're interested in`,
defaultMessage: 'Are you looking to expand your knowledge? Enrolling in a Program lets you take a series of courses in the subject that you\'re interested in',
},
});

Expand Down
2 changes: 1 addition & 1 deletion src/containers/UnenrollConfirmModal/components/messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const messages = defineMessages({
reasonHeading: {
id: 'learner-dash.unenrollConfirm.confirm.reason.heading',
description: 'Heading for unenroll reason modal',
defaultMessage: `What's your main reason for unenrolling?`,
defaultMessage: 'What\'s your main reason for unenrolling?',
},
reasonSkip: {
id: 'learner-dash.unenrollConfirm.confirm.reason.skip',
Expand Down
8 changes: 4 additions & 4 deletions src/containers/UnenrollConfirmModal/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const messages = defineMessages({
[reasonKeys.prereqs]: {
id: 'learner-dash.unenrollConfirm.reasons.prereqs',
description: 'Unenroll reason option - missing prerequisites',
defaultMessage: `I don't have the academic or language prerequisites`,
defaultMessage: 'I don\'t have the academic or language prerequisites',
},
[reasonKeys.difficulty]: {
id: 'learner-dash.unenrollConfirm.reasons.difficulty',
Expand All @@ -41,7 +41,7 @@ const messages = defineMessages({
[reasonKeys.goals]: {
id: 'learner-dash.unenrollConfirm.reasons.goals',
description: 'Unenroll reason option - goals-related',
defaultMessage: `This won't help me reach my goals`,
defaultMessage: 'This won\'t help me reach my goals',
},
[reasonKeys.broken]: {
id: 'learner-dash.unenrollConfirm.reasons.broken',
Expand All @@ -51,7 +51,7 @@ const messages = defineMessages({
[reasonKeys.time]: {
id: 'learner-dash.unenrollConfirm.reasons.time',
description: 'Unenroll reason option - time-related',
defaultMessage: `I don't have the time`,
defaultMessage: 'I don\'t have the time',
},
[reasonKeys.browse]: {
id: 'learner-dash.unenrollConfirm.reasons.browse',
Expand All @@ -61,7 +61,7 @@ const messages = defineMessages({
[reasonKeys.support]: {
id: 'learner-dash.unenrollConfirm.reasons.support',
description: 'Unenroll reason option - lacking support',
defaultMessage: `I don't have enough support`,
defaultMessage: 'I don\'t have enough support',
},
[reasonKeys.quality]: {
id: 'learner-dash.unenrollConfirm.reasons.quality',
Expand Down
11 changes: 11 additions & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
Copy link
Author

@PKulkoRaccoonGang PKulkoRaccoonGang Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[inform]: The addition of tsconfig.json is caused by an error when importing the TS file from the header.

Module './StudioHeader' was resolved to '/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learner-dashboard/node_modules/@edx/frontend-component-header/dist/studio-header/StudioHeader.tsx', but '--jsx' is not set.

"extends": "@edx/typescript-config",
"compilerOptions": {
"baseUrl": "./src",
"paths": {
"*": ["*"]
}
},
"include": ["*.js", ".eslintrc.js", "src/**/*", "plugins/**/*", "jest.config.ts"],
"exclude": ["dist", "node_modules"],
}