Feat: Home tab[0092] #462

PavloNetrebchuk · 2025-09-04T15:14:34Z

Portrait

Screen.Recording.2025-09-04.at.18.12.34.mov

Landscape

Screen.Recording.2025-09-04.at.18.15.32.mov

Tablet

Screen.Recording.2025-09-04.at.18.17.28.mov

Dart Theme

openedx-webhooks · 2025-09-04T15:14:39Z

Thanks for the pull request, @PavloNetrebchuk!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

course/src/test/java/org/openedx/course/presentation/home/CourseHomeViewModelTest.kt

IvanStepanok

LGTM

IvanStepanok · 2025-09-08T06:30:17Z

core/src/main/java/org/openedx/core/Mock.kt

In case we will use this file for tests only, probably we can move it to core/src/test or to debug/testFixtures?

Not only tests. Also preview functions

IvanStepanok · 2025-09-08T06:34:37Z

course/src/main/java/org/openedx/course/presentation/home/CourseHomeViewModel.kt

+
+            val downloadableBlocks = blocks.filter { it.isDownloadable }
+            val downloadingBlocks = blocksIds.filter { isBlockDownloading(it) }
+            val isAllBlocksDownloaded = downloadableBlocks.all { isBlockDownloaded(it.id) }


Will return true in case when we have downloadableBlocks empty. Is it okay?

IvanStepanok · 2025-09-08T06:38:04Z

core/src/main/java/org/openedx/core/utils/TimeUtils.kt

+    fun formatToDayMonth(date: Date): String {
+        val sdf = SimpleDateFormat("MMM dd", Locale.getDefault())
+        return sdf.format(date)
+    }


It returns Month to Day but named as a DayMonth

IvanStepanok · 2025-09-08T06:40:17Z

course/src/main/java/org/openedx/course/presentation/home/CourseHomeScreen.kt

+        scaffoldState = scaffoldState,
+        backgroundColor = MaterialTheme.appColors.background
+    ) {
+        val screenWidth by remember(key1 = windowSize) {


screenWithModifier?

edschema · 2025-09-23T05:24:21Z

@PavloNetrebchuk nice work! A few notes:
For the progress bar on the grade carousel card, can you add a background? It should be "light theme: light" and "dark theme: light" for light mode/dark mode

For the Assignments carousel card, for upcoming assignment, can you add the header "Next Assignment":

Also for the assignments card: just want to make sure the text is correct: larger text is subsection name, smaller is the section name

For the first and third cards (course completion, assignments), can the background color be the same as the page dark color:

For the Video card: if the video has not been started, the text should read "Next Video". Continue watching is for videos that are started but not yet finished.

PavloNetrebchuk · 2025-09-23T10:12:01Z

@edschema
Done✅

Also for the assignments card: just want to make sure the text is correct: larger text is subsection name, smaller is the section name
Yes, it is correct.

stan-neichev · 2025-09-23T12:28:05Z

For the Assignments carousel card, for upcoming assignment, can you add the header "Next Assignment":

Hi @edschema! It's out of scope because the actual design is the following:

edschema · 2025-09-23T12:36:16Z

@stan-neichev that’s for past due assignments. For upcoming assignments, we wouldn’t say “past due”

stan-neichev · 2025-09-23T12:37:36Z

sorry, let me check with the team

stan-neichev · 2025-09-23T13:05:08Z

@edschema seems like we had no design for other states and therefore we decided to do it this way:

Also, our QA noticed that we had another background color for this element

Please don't change the design on the fly because it's hard to trace it back to the initial state and have a more or less stable scope of work

edschema · 2025-09-23T13:28:35Z

Hi Stan, these states have been in the file since the early designs, see here, here, and here. We can discuss a lower lift solution if this is too much.

For the background, the screenshot you shared is correct, the assignments card and the background of the page should be the same:

PavloNetrebchuk · 2025-09-25T09:24:47Z

All changes have been made✅

edschema · 2025-09-26T12:57:33Z

Thank you @PavloNetrebchuk. Is this ready for code review? Thank you!

RawanMatar89

LGTM👍🏻Thank you for the effort 👏🏻

RawanMatar89 · 2025-10-05T05:05:30Z

course/src/main/java/org/openedx/course/data/repository/CourseRepository.kt

+    fun getCourseProgress(
+        courseId: String,
+        isRefresh: Boolean,
+        getOnlyCacheIfExist: Boolean


will you please consider documenting this new parameter's behavior clearly

course/src/main/java/org/openedx/course/presentation/unit/container/CourseViewMode.kt

PavloNetrebchuk added 9 commits September 2, 2025 13:18

feat: course home pager and pager indicator with navigation

f7cfb43

feat: course completion pager tab

5ac6548

feat: move HomeNavigationRow to bottom bar

7d6610f

feat: course home pages videos card

8625632

feat: course home pages assignment card

d1ed4bf

feat: course home pages grades card

87da809

feat: added empty states

2ce9ceb

feat: CaughtUpMessage

11657ff

feat: A11y

c9f3cbe

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 4, 2025

openedx-webhooks added this to Contributions Sep 4, 2025

github-project-automation bot moved this to Needs Triage in Contributions Sep 4, 2025

PavloNetrebchuk requested review from IvanStepanok and volodymyr-chekyrta September 4, 2025 15:14

PavloNetrebchuk self-assigned this Sep 4, 2025

PavloNetrebchuk changed the title ~~Feat: Home tab[0098]~~ Feat: Home tab[0092] Sep 4, 2025

feat: detekt fixes

36e49ac

PavloNetrebchuk force-pushed the feat/home_tab branch from 222b7f0 to 36e49ac Compare September 4, 2025 15:25

PavloNetrebchuk added 2 commits September 5, 2025 15:18

feat: changes according demo feedback

05fc280

feat: course home analytic

42eda19

PavloNetrebchuk force-pushed the feat/home_tab branch from 133f489 to 42eda19 Compare September 5, 2025 14:21

feat: CourseHomeViewModelTest

a408106

github-advanced-security bot found potential problems Sep 5, 2025

View reviewed changes

IvanStepanok approved these changes Sep 8, 2025

View reviewed changes

PavloNetrebchuk force-pushed the feat/home_tab branch 2 times, most recently from c28f338 to 40aa01f Compare September 10, 2025 13:04

mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Sep 10, 2025

PavloNetrebchuk force-pushed the feat/home_tab branch 2 times, most recently from 0472ff6 to 6381aca Compare September 11, 2025 10:10

PavloNetrebchuk force-pushed the feat/home_tab branch 2 times, most recently from a6a85e2 to f7992ae Compare September 22, 2025 15:12

PavloNetrebchuk force-pushed the feat/home_tab branch from f7992ae to 57c3f93 Compare September 23, 2025 10:11

PavloNetrebchuk force-pushed the feat/home_tab branch 2 times, most recently from a80ed4d to ff18188 Compare September 23, 2025 11:54

PavloNetrebchuk force-pushed the feat/home_tab branch from ff18188 to 47a5ba0 Compare September 23, 2025 12:40

PavloNetrebchuk force-pushed the feat/home_tab branch from 47a5ba0 to 9e98256 Compare September 23, 2025 17:45

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Sep 24, 2025

edschema mentioned this pull request Sep 26, 2025

Course Home openedx/openedx-app-ios#616

Closed

edschema requested a review from RawanMatar89 October 3, 2025 12:59

RawanMatar89 approved these changes Oct 5, 2025

View reviewed changes

feat: changes according PR feedback

71cc7de

PavloNetrebchuk force-pushed the feat/home_tab branch from 9e98256 to 71cc7de Compare October 6, 2025 11:07

github-advanced-security bot found potential problems Oct 7, 2025

View reviewed changes

course/src/main/java/org/openedx/course/presentation/unit/container/CourseViewMode.kt Fixed Show fixed Hide fixed

course/src/main/java/org/openedx/course/presentation/unit/container/CourseViewMode.kt Fixed Show fixed Hide fixed

feat: changes according PR feedback

762ffe2

PavloNetrebchuk force-pushed the feat/home_tab branch from b9117cf to 762ffe2 Compare October 7, 2025 12:11

volodymyr-chekyrta approved these changes Oct 7, 2025

View reviewed changes

volodymyr-chekyrta merged commit f3ffa98 into openedx:develop Oct 7, 2025
6 checks passed

github-project-automation bot moved this from In Eng Review to Done in Contributions Oct 7, 2025

volodymyr-chekyrta deleted the feat/home_tab branch October 7, 2025 12:50

PavloNetrebchuk mentioned this pull request Oct 23, 2025

Release v2.2 (Ulmo.1) #465

Merged

Feat: Home tab[0092] #462

Feat: Home tab[0092] #462

Uh oh!

Conversation

PavloNetrebchuk commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openedx-webhooks commented Sep 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IvanStepanok left a comment

Choose a reason for hiding this comment

Uh oh!

IvanStepanok Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

PavloNetrebchuk Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

IvanStepanok Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

IvanStepanok Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

IvanStepanok Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

edschema commented Sep 23, 2025

Uh oh!

PavloNetrebchuk commented Sep 23, 2025

Uh oh!

stan-neichev commented Sep 23, 2025

Uh oh!

edschema commented Sep 23, 2025

Uh oh!

stan-neichev commented Sep 23, 2025

Uh oh!

stan-neichev commented Sep 23, 2025

Uh oh!

edschema commented Sep 23, 2025

Uh oh!

PavloNetrebchuk commented Sep 25, 2025

Uh oh!

edschema commented Sep 26, 2025

Uh oh!

RawanMatar89 left a comment

Choose a reason for hiding this comment

Uh oh!

RawanMatar89 Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

PavloNetrebchuk commented Sep 4, 2025 •

edited

Loading