-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Adds MFE_CONFIG toggle to toggle the settings #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @farhaanbukhsh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
tutornotifications/plugin.py
Outdated
| # Prefix your setting names with 'NOTIFICATIONS_'. | ||
| ("NOTIFICATIONS_VERSION", __version__), | ||
| ("NOTIFICATIONS_ENABLE_SHOW_EMAIL_CHANNEL", True), | ||
| ("NOTIFICATIONS_ENABLE_SHOW_PUSH_CHANNEL", True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To set this as the default, please assign an empty string or completely remove it. ("NOTIFICATIONS_ENABLE_SHOW_PUSH_CHANNEL", '')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ("NOTIFICATIONS_ENABLE_SHOW_PUSH_CHANNEL", True), | |
| ("NOTIFICATIONS_ENABLE_SHOW_PUSH_CHANNEL", False), |
@awais-ansari this should work right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this will be considered a "False" string in MFE. The Boolean value of "False" will be considered as true. You either need to remove it or assign an empty string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@awais-ansari I have made the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farhaanbukhsh This change will enable both channels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@awais-ansari I think it will be confusing if we go with the approach of removing the value possibly we should fix something like how ENABLE_ACCOUNT_DELETION is working here, what do you think? cc: @bmtcril
Signed-off-by: Farhaan Bukhsh <[email protected]>
6ae2591 to
1f4704c
Compare
The PR add the a way to toggle the settings for notification under Account of the user. These are turned on by default and can later be turned of using config.
Adds the fix that is done in #29