Skip to content

Conversation

@farhaanbukhsh
Copy link
Member

@farhaanbukhsh farhaanbukhsh commented Nov 24, 2025

The PR add the a way to toggle the settings for notification under Account of the user. These are turned on by default and can later be turned of using config.

Adds the fix that is done in #29

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 24, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @farhaanbukhsh!

This repository is currently maintained by @openedx/committers-tutor-contrib-notifications.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

# Prefix your setting names with 'NOTIFICATIONS_'.
("NOTIFICATIONS_VERSION", __version__),
("NOTIFICATIONS_ENABLE_SHOW_EMAIL_CHANNEL", True),
("NOTIFICATIONS_ENABLE_SHOW_PUSH_CHANNEL", True),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To set this as the default, please assign an empty string or completely remove it. ("NOTIFICATIONS_ENABLE_SHOW_PUSH_CHANNEL", '')

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
("NOTIFICATIONS_ENABLE_SHOW_PUSH_CHANNEL", True),
("NOTIFICATIONS_ENABLE_SHOW_PUSH_CHANNEL", False),

@awais-ansari this should work right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this will be considered a "False" string in MFE. The Boolean value of "False" will be considered as true. You either need to remove it or assign an empty string.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awais-ansari I have made the changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhaanbukhsh This change will enable both channels.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awais-ansari I think it will be confusing if we go with the approach of removing the value possibly we should fix something like how ENABLE_ACCOUNT_DELETION is working here, what do you think? cc: @bmtcril

@farhaanbukhsh farhaanbukhsh force-pushed the farhaan/adding-environment-variable branch from 6ae2591 to 1f4704c Compare November 25, 2025 14:13
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Nov 25, 2025
@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Nov 25, 2025
@farhaanbukhsh farhaanbukhsh merged commit 2b03ccc into main Nov 25, 2025
3 checks passed
@farhaanbukhsh farhaanbukhsh deleted the farhaan/adding-environment-variable branch November 25, 2025 15:01
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants