refactor: Remove parsel dependency and fix other issues #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Member
|
@Waleed-Mujahid, I just updated the deps in this repo. Could you please rebase your PR on the latest version of the |
…plorerBlock - Replaced the `_change_relative_url_to_absolute` method with `_replace_relative_static_urls` to utilize a service for URL replacement. - Updated JavaScript to notify runtime on save completion. - Removed parsel from requirements as it is no longer needed. - Upgraded various dependencies in requirements files.
These buttons need to be loaded in both lms and studio explanation: openedx#83 (comment)
Waleed-Mujahid
force-pushed
the
waleed/fix-197
branch
from
5c8662a to
28d17e1
Compare
Author
|
@Agrendalath Done |
Waleed-Mujahid
force-pushed
the
waleed/fix-197
branch
from
da04df4 to
e17aaa4
Compare
Author
|
@Agrendalath @farhaanbukhsh Any feedback on this PR? |
Member
|
Hi @Waleed-Mujahid, I will test this later this week. In the meantime, could you please update the minor version when you have a moment? |
Agrendalath
approved these changes
Jan 9, 2026
Member
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
@Waleed-Mujahid, sorry for the delay on this review. Please bump the version to 3.1.0.
👍
- I tested this: checked that the XBlock can be installed in Teak, and replaces the relative links correctly
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
| import logging | ||
| import textwrap | ||
| from io import StringIO | ||
| from urllib.parse import urljoin |
Member
There was a problem hiding this comment.
Suggested change
Nit: urljoin is not needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_change_relative_url_to_absolutemethod with_replace_relative_static_urlsto utilize a service for URL replacement.Fixes: #197