Fix crash when suffix has https:// because of a broken link#167
Open
lisotton wants to merge 1 commit intoopeneuropa:masterfrom
Open
Fix crash when suffix has https:// because of a broken link#167lisotton wants to merge 1 commit intoopeneuropa:masterfrom
lisotton wants to merge 1 commit intoopeneuropa:masterfrom
Conversation
lisotton
commented
Sep 23, 2025
| * The suffix. | ||
| */ | ||
| public function getSuffixFromPath(string $path): string { | ||
| $parsed = UrlHelper::parse($path); |
Contributor
Author
There was a problem hiding this comment.
Note for reviewer: why calling UrlHelper:parse if the content of $path is already expected to be a path, without query string and fragment?
Where this function is called, it is the result of $request->getPathInfo(), which already return only the path part of the URL. This can be seen in the documentation of the function:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #155.