Skip to content

Fix crash when suffix has https:// because of a broken link #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lisotton wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix crash when suffix has https:// because of a broken link #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/oe_multilingual_url_suffix/src/UrlSuffixTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ public function getUrlSuffixes(string $path = ''): array {
* The suffix.
*/
public function getSuffixFromPath(string $path): string {
$parsed = UrlHelper::parse($path);
Copy link
Contributor Author

@lisotton lisotton Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewer: why calling UrlHelper:parse if the content of $path is already expected to be a path, without query string and fragment?
Where this function is called, it is the result of $request->getPathInfo(), which already return only the path part of the URL. This can be seen in the documentation of the function:
image

$path = urldecode(trim($parsed['path'], '/'));
$path = urldecode(trim($path, '/'));
$parts = explode(LanguageNegotiationUrlSuffix::SUFFIX_DELIMITER, $path);
return $parts ? array_pop($parts) : '';
}
Expand Down