Replace static classes FmDB and FmFuncAdmin by namespaces#38
Merged
kmokstad merged 3 commits intoopenfedem:mainfrom Dec 24, 2025
Merged
Replace static classes FmDB and FmFuncAdmin by namespaces#38kmokstad merged 3 commits intoopenfedem:mainfrom
kmokstad merged 3 commits intoopenfedem:mainfrom
Conversation
kmokstad
force-pushed
the
static-to-namespace
branch
4 times, most recently
from
d961ce6 to
5c3f324
Compare
kmokstad
force-pushed
the
static-to-namespace
branch
from
5c3f324 to
9a973c5
Compare
Add utility function FmDB::unknownKeyword(). Change the signature of some FmDB functions taking a FmHeadMap pointer as argument instead of a reference. NULL then defaults to ourHeadMap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The classes with static methods only are now replaced by equivalent namespaces for the convenience.
The static methods that used to be declared as private (or protected) are now defined in anonymous namespaces in the implementation file instead and therefore do not need be be declared in header files (same with the private attributes), making the header files shorter.